Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 492821 - Smart import wizard - UI issues
Summary: Smart import wizard - UI issues
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on: 492020 495009
Blocks:
  Show dependency tree
 
Reported: 2016-05-02 09:53 EDT by Noopur Gupta CLA
Modified: 2020-02-02 10:23 EST (History)
5 users (show)

See Also:


Attachments
Screenshot (73.74 KB, image/png)
2016-05-02 09:53 EDT, Noopur Gupta CLA
no flags Details
Screenshot - Buttons (52.90 KB, image/png)
2016-05-03 08:19 EDT, Noopur Gupta CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2016-05-02 09:53:54 EDT
Created attachment 261408 [details]
Screenshot

Eclipse 4.6 M7

- Create folder C:\Eclipse1 in your system.
- In "Import projects" wizard, select the above directory. 
=> The result in the table misses the first letter of the folder. This can be seen on Linux also. See attached screenshot.

Other UI issues:
- The wizard's title should be "Import Projects" ('p' in capital) similar to the existing import wizards.
- The "Select/Deselect All" buttons are too wide and should probably be placed next to the table instead of the filter.
Comment 1 Lars Vogel CLA 2016-05-02 10:22:41 EDT
I think the title should match the menu entry and therefore should be "Open Projects". We have already a bug for that inconsistent naming.
Comment 2 Lars Vogel CLA 2016-05-02 10:27:43 EDT
(In reply to Lars Vogel from comment #1)
> I think the title should match the menu entry and therefore should be "Open
> Projects". We have already a bug for that inconsistent naming.

See Bug 492020
Comment 3 Noopur Gupta CLA 2016-05-03 07:51:58 EDT
(In reply to Lars Vogel from comment #2)
> (In reply to Lars Vogel from comment #1)
> > I think the title should match the menu entry and therefore should be "Open
> > Projects". We have already a bug for that inconsistent naming.
> 
> See Bug 492020

Sure. 

It would be good to fix the other two issues also for 4.6.

(In reply to Noopur Gupta from comment #0)
> => The result in the table misses the first letter of the folder. This can
> be seen on Linux also. See attached screenshot.

Reproducible on Mac also.

(In reply to Noopur Gupta from comment #0)
> - The "Select/Deselect All" buttons are too wide and should probably be
> placed next to the table instead of the filter.

Or, the check box "Hide..." can be moved down (along with the buttons, if required), similar to the Import > Plug-in Development > Features wizard.
Comment 4 Rüdiger Herrmann CLA 2016-05-03 08:09:20 EDT
(In reply to Noopur Gupta from comment #0)
> - The "Select/Deselect All" buttons are too wide and should probably be
> placed next to the table instead of the filter.

"Select/Deselect All" buttons have the default button width (see bug 491949) so that all buttons in the wizard have the same width. This is also in line with how other dialogs/wizards size their buttons.
Comment 5 Noopur Gupta CLA 2016-05-03 08:19:11 EDT
Created attachment 261427 [details]
Screenshot - Buttons

(In reply to Rüdiger Herrmann from comment #4)
> (In reply to Noopur Gupta from comment #0)
> > - The "Select/Deselect All" buttons are too wide and should probably be
> > placed next to the table instead of the filter.
> 
> "Select/Deselect All" buttons have the default button width (see bug 491949)
> so that all buttons in the wizard have the same width. This is also in line
> with how other dialogs/wizards size their buttons.

In M7 build, I can see that "Select/Deselect All" buttons are wider than the other buttons in the wizard. See attached screenshot.
Comment 6 Lars Vogel CLA 2016-07-21 14:51:39 EDT
(In reply to Noopur Gupta from comment #5)
> In M7 build, I can see that "Select/Deselect All" buttons are wider than the
> other buttons in the wizard. See attached screenshot.

I see this also still in 4.7. Mickael, can you have a look?
Comment 7 Mickael Istria CLA 2016-07-22 06:12:50 EDT
(In reply to Noopur Gupta from comment #3)
> Or, the check box "Hide..." can be moved down (along with the buttons, if
> required), similar to the Import > Plug-in Development > Features wizard.

The checkboxes below actually control the actual actions that are going to be performed by the import, whereas the "Hide" one only control the UI (similar as the filter field). I'd rather avoiding to mix both as they don't have the same "criticity".
Maybe this "hide already imported project" checkbox should be moved up, next to the filter text widget?
Comment 8 Dani Megert CLA 2016-08-10 10:10:43 EDT
M1 is done. Moving to M2.
Comment 9 Mickael Istria CLA 2017-05-24 10:36:52 EDT
Some of those issues are fixed, some others (button size) are still present (as I don't think we can easily hack the FilteredTree rendering, but I didn't check).
Anyway, nothing worth an RC.
I'm unassigning those to make sure anyone interested can feel welcome to fix it. I keep it in my personal todo-list but cannot say when I get the opportunity to improve this.
Comment 10 Mickael Istria CLA 2017-05-24 10:49:30 EDT
The remaining issues are minor ones.
Comment 11 Eclipse Genie CLA 2020-02-02 10:23:41 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.