Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 492807 - Mac-cocoa Eclipse.app has invalid Info.plist and signing issues
Summary: Mac-cocoa Eclipse.app has invalid Info.plist and signing issues
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.6   Edit
Hardware: PC Mac OS X
: P2 critical (vote)
Target Milestone: 4.6 RC1   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard: routine releng
Keywords:
Depends on:
Blocks: 492822
  Show dependency tree
 
Reported: 2016-05-02 06:35 EDT by Lakshmi P Shanmugam CLA
Modified: 2016-06-04 03:39 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lakshmi P Shanmugam CLA 2016-05-02 06:35:32 EDT
Tested with I20160428-8000, I20160430-2000 builds

Extract the downloaded tar.gz file. It is extracted as eclipse.app instead of Eclipse.app.
Trying to run eclipse.app fails with this msg: "Eclipse is damaged and can't be opened. You should move it trash."
I tried to verify the signature using codesign -v, I get "eclipse.app/: invalid Info.plist (plist or signature have been modified)"
Using codesign -dv eclipse.app, I get "Signature=adhoc
Info.plist=not bound"

More info:
Security and Privacy settings in Preferences is set to :
Allow apps downloaded from: Mac App Store an identified developers
Comment 1 Markus Keller CLA 2016-05-02 09:49:20 EDT
FYI here are some more data points. I don't understand why my observations are so much different from Lakshmi's.

eclipse-SDK-4.6M7-macosx-cocoa-x86_64.tar.gz extracts and runs fine for me, and

$ codesign -v eclipse.app

prints this (on OS X 10.11):

eclipse.app: code object is not signed at all
In architecture: x86_64

I still have a pending update for Xcode 7.3 in the App Store. That could make a difference or not.


Extracting and running eclipse-platform-I20160501-2000-macosx-cocoa-x86_64.tar.gz gives me a dialog with:

“Eclipse.app” can’t be opened because it is from an unidentified developer.
Your security preferences allow installation of only apps from the Mac App Store and identified developers.



I find the lowercase "eclipse.app" app folder quite confusing and would prefer a folder that has the same name as the app shown in the Finder.
Comment 2 David Williams CLA 2016-05-02 09:58:22 EDT
Thanks for reporting. 

I have reproduced using the explicit checks for signature verification. I guess it "runs on my machine" because I have loosened security settings, or similar. 

My guess is you are correct and related to bug 491626#c9. 

In fact, I have opened a new bug 492822 so I can be very explicit about the name of "Eclipse.app".
Comment 3 David Williams CLA 2016-05-02 10:43:04 EDT
For this bug, will first try changing the name back to "Eclipse.app" for tonight's (5/2) I-build and see if that fixes things, before investigating any deeper.
Comment 4 David Williams CLA 2016-05-03 00:07:27 EDT
Confirmed in build I20160502-2000 that changing the case back to initial uppercase letter fixed the signature verification. 

I suspect there is a signing or Tycho improvement that could be made here, but am not sure what it is.
Comment 5 Lakshmi P Shanmugam CLA 2016-05-03 02:51:11 EDT
Verified with I20160502-2000.
The download is extracted as Eclipse.app and eclipse comes up fine as expected.
Also, verified using codesign that the app is signed by Eclipse Foundation.
Comment 6 Ernesto Posse CLA 2016-06-03 16:55:04 EDT
Is this related to Bug 391455 or Bug 241613?
Comment 7 David Williams CLA 2016-06-04 03:39:31 EDT
(In reply to Ernesto Posse from comment #6)
> Is this related to Bug 391455 or Bug 241613?

Should not be related. This issue existed as a problem for a relatively short period during M7 development of Neon. If you are testing anything past RC1 (and you should be :) then it should no longer be an issue. 

[I suppose it might be if you just used "update" continuously -- you might need a fresh install since the Mac normally has a "case-preserving, but case ignoring" file system you might have some entries for 'eclipse.app' and some entries for 'Eclipse.app" and I have no idea how the Mac would treat those.] 

I have made further comments in bug 241613 to help you distinguish "bugs in the Eclipse Installer" vs. "bugs in the Eclipse SDK". 

Thanks,