Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #489087 +++ We should find a good shortcut to toogle the full screen mode.
For summarize what are the previous rejected propositions : - F11 : already taken by JDT (and will not be released) - Ctrl+F11 : already taken by JDT (and will not be released) - Ctrl+ALT+X should be avoid. See See https://bugs.eclipse.org/bugs/show_bug.cgi?id=477451#c10 - Alt+Enter : already taken by Eclipse (project properties) I suggest Alt+F11.
(In reply to Gautier de SAINT MARTIN LACAZE from comment #1) > For summarize what are the previous rejected propositions : > > - F11 : already taken by JDT (and will not be released) > - Ctrl+F11 : already taken by JDT (and will not be released) > - Ctrl+ALT+X should be avoid. See See > https://bugs.eclipse.org/bugs/show_bug.cgi?id=477451#c10 > - Alt+Enter : already taken by Eclipse (project properties) > > > I suggest Alt+F11. Already taken, please check the existing keybindings before suggesting something. Also Ctrl+Alt+<X> shortcuts cannot be used. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=477451#c10
(In reply to Lars Vogel from comment #2) > > I suggest Alt+F11. Ah, sorry. Alt+F11 seems available.
+1 for Alt+F11.
On OS X, the system standard is Cmd-Ctrl-F.
(In reply to Brian de Alwis from comment #5) > On OS X, the system standard is Cmd-Ctrl-F. We could add multiple binding for the same operation, to also provide the OSX binding.
(In reply to Mickael Istria from comment #6) > (In reply to Brian de Alwis from comment #5) > > On OS X, the system standard is Cmd-Ctrl-F. > > We could add multiple binding for the same operation, to also provide the > OSX binding. Sounds like we have to, as cmd dies not exists for Linux and Win
(In reply to Lars Vogel from comment #7) > (In reply to Mickael Istria from comment #6) > > (In reply to Brian de Alwis from comment #5) > > > On OS X, the system standard is Cmd-Ctrl-F. > > > > We could add multiple binding for the same operation, to also provide the > > OSX binding. > > Sounds like we have to, as cmd dies not exists for Linux and Win Not in general. Different ones should be assigned depending on the OS.
Assigning to myself for investigation.
New Gerrit change created: https://git.eclipse.org/r/70839
Please, review the associated change.
Gerrit change https://git.eclipse.org/r/70839 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=36ee5fd91a6d6159fed6eab826608acc3a915fa6
Thanks Patrik
According to Brian's comment on Change 70839 the binding should be fixed using a proper style -> M3+F11 Another question raised is: Given that M3+F11 is already used in Cocoa and Carbon, which Keyboard Shortcut shall we use for fullscreen? Note: If we can agree I'm going to add the cocoa+carbon binding to the next change, that I'll push shortly. Otherwise, I'm going to open a follow-up bug to address this later.
(In reply to Patrik Suzzi from comment #14) > According to Brian's comment on Change 70839 the binding should be fixed > using a proper style -> M3+F11 > > Another question raised is: > Given that M3+F11 is already used in Cocoa and Carbon, which Keyboard > Shortcut shall we use for fullscreen? I think Mac has its own shortcut for using full screen. Can you add the M3+F11 only for Linux and Windows?
(In reply to Lars Vogel from comment #15) > I think Mac has its own shortcut for using full screen. Can you add the > M3+F11 only for Linux and Windows? Use the 'platform' attribute on the keybinding.
New Gerrit change created: https://git.eclipse.org/r/70876
Please review the attached change.
Gerrit change https://git.eclipse.org/r/70876 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0add3b0043df7fbfc283bdca23e8ad1a29928b4c
Thanks Brian for finding issues and Patrik for fixing them. The shortcut is now specific for Linux and Window. Mac has already an existing shortcut for that.
After switching to full screen, a tooltip window with a message like "You have gone full screen ... <steps to go back> ..." is shown. Wouldn't it be useful to add a hint for the key binding to this tooltip?
(In reply to Rüdiger Herrmann from comment #21) > After switching to full screen, a tooltip window with a message like "You > have gone full screen ... <steps to go back> ..." is shown. > Wouldn't it be useful to add a hint for the key binding to this tooltip? Yes, see Bug 491785.
The Extras for Eclipse plug-in uses the same key binding (Alt+F11) to open a Launch Dialog [1]. This dialog, similar to 'Open Type', lists all launch configurations and allows to start or edit the selected items. I am aware that F11 is used in browsers to go full-screen and therefore Alt+F11 may have seemed an obvious choice. But historically, in Eclipse, 'F11-based' key bindings are used for launching things - think of F11 (Debug), Ctrl+F11 (Run), Shift+Ctrl+F11 (Coverage). And for this reason, I have chosen Alt+F11 for the launch dialog. Therefore, I'm asking to use a different key binding for the full-screen command. Would Shift+F12 be a viable alternative? [1] https://github.com/rherrmann/eclipse-extras#launch-configuration-selection-dialog
(In reply to Rüdiger Herrmann from comment #23) > The Extras for Eclipse plug-in uses the same key binding (Alt+F11) to open a > Launch Dialog [1]. This dialog, similar to 'Open Type', lists all launch > configurations and allows to start or edit the selected items. > > Therefore, I'm asking to use a different key binding for the full-screen > command. Would Shift+F12 be a viable alternative? > I personally think the browser analogy is a good argument to keep the existing shortcut. We also asked via Platform.ui mailing list for feedback a while ago, which lead to this shortcut. -1 for a change now, we are about to release M7.
(In reply to Lars Vogel from comment #24) > (In reply to Rüdiger Herrmann from comment #23) > > The Extras for Eclipse plug-in uses the same key binding (Alt+F11) to open a > > Launch Dialog [1]. This dialog, similar to 'Open Type', lists all launch > > configurations and allows to start or edit the selected items. > > > > Therefore, I'm asking to use a different key binding for the full-screen > > command. Would Shift+F12 be a viable alternative? > > > I personally think the browser analogy is a good argument to keep the > existing shortcut. We also asked via Platform.ui mailing list for feedback a > while ago, which lead to this shortcut. -1 for a change now, > we are about to release M7. Sorry for being late here, I didn't follow the Platform/UI mailing list. Given that Eclipse isn't a browser, how does Akt+F11 to go full-screen fit into the picture if all other F11 bindings are used for launching?
