Description Christian Damus 2016-04-11 17:25:38 EDT

The RuntimeValuesAdviceEditHelperAdvice checks whether the incoming advice has the parameter allowing cancellation of the dialog (why is this even an option? Every dialog asking for user input should be cancellable) but then just ignores the possibility that the dialog was cancelled.

In the doExecuteWithResult(...) method of the after-configure command is:

    Set<View> viewsToDisplay = getViewsToDisplay();
    if (!viewsToDisplay.isEmpty()) {
        EditionDialog dialog = new EditionDialog(...);
        dialog.setTitle("Edit " + EMFCoreUtil.getName(elementToConfigure));
        dialog.setViews(viewsToDisplay);
        dialog.setInput(elementToConfigure);

        dialog.open();
    }

    return CommandResult.newOKCommandResult(elementToConfigure);

So, we unconditionally complete the command, regardless of the dialog's return code.