491318 – Spinner/DateTime rendered broken if created without SWT.BORDER on Gtk 3.20

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 491318 - Spinner/DateTime rendered broken if created without SWT.BORDER on Gtk 3.20

Summary: Spinner/DateTime rendered broken if created without SWT.BORDER on Gtk 3.20

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.5
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.6 M7
Assignee:	Alexander Kurtakov
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-04-08 06:29 EDT by Alexander Kurtakov
Modified:	2016-04-26 09:05 EDT (History)
CC List:	2 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Spinner (104.21 KB, image/png) 2016-04-08 06:32 EDT, Alexander Kurtakov	no flags	Details
DateTime (109.07 KB, image/png) 2016-04-08 06:32 EDT, Alexander Kurtakov	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Kurtakov

2016-04-08 06:29:37 EDT

SWT.BORDER support was added in a hackish way by abusing gtk_entry_set_has_frame and setting it to false when no border param passed. While this may be fine for GtkEntry in general it breaks the more advanced widgets built on top of it which assume they have frame.

Comment 1 Alexander Kurtakov

2016-04-08 06:32:37 EDT

Created attachment 260803 [details]
Spinner

Comment 2 Alexander Kurtakov

2016-04-08 06:32:59 EDT

Created attachment 260804 [details]
DateTime

Comment 3 Eclipse Genie

2016-04-08 06:42:36 EDT

New Gerrit change created: https://git.eclipse.org/r/70224

Comment 4 Eclipse Genie

2016-04-08 06:49:08 EDT

Gerrit change https://git.eclipse.org/r/70224 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=70bd192b1f4af1964bb8ba81c3321bdd27831c43

Comment 5 Alexander Kurtakov

2016-04-08 06:53:37 EDT

In master now.

Comment 6 Sravan Kumar Lakkimsetti

2016-04-26 02:59:26 EDT

Hi Eric,

Can you please verify this for M7 milestone build?

Thanks
Sravan

Comment 7 Eric Williams

2016-04-26 09:05:20 EDT

(In reply to Sravan Kumar Lakkimsetti from comment #6)
> Hi Eric,
> 
> Can you please verify this for M7 milestone build?
> 
> Thanks
> Sravan

Verified fixed in N20160423-1500.