Community
Participate
Working Groups
Per a discussion on ptp-dev, we need to split the pldt.openacc plug-in into two plug-ins--core and UI--before contributing OpenACC refactoring support. We also want to add code for running refactorings from the command line; it might make sense to put this code in a separate CLI plug-in, since it cannot/should not be compiled into the Eclipse plug-in.
New Gerrit change created: https://git.eclipse.org/r/69937
New Gerrit change created: https://git.eclipse.org/r/69952
New Gerrit change created: https://git.eclipse.org/r/70527
New Gerrit change created: https://git.eclipse.org/r/70526
New Gerrit change created: https://git.eclipse.org/r/70525
New Gerrit change created: https://git.eclipse.org/r/70528
Trying again to squash this into a single change...
New Gerrit change created: https://git.eclipse.org/r/70529
Gerrit change https://git.eclipse.org/r/70529 was merged to [master]. Commit: http://git.eclipse.org/c/ptp/org.eclipse.ptp.git/commit/?id=75653772ce3a2b9f44374e5f4b96e1c13858fed8
You should really have a Signed-off-by: line in the commit message. I'm not sure why it accepted the change without one...
Hmm, I was following the command line instructions at https://wiki.eclipse.org/Gerrit with the commit-msg hook <https://wiki.eclipse.org/Gerrit#Gerrit_Code_Review_Cheatsheet>. I guess it generates the Change ID but not the other.
Ah, well if you'd used Eclipse then it would have done it for you...