Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 48827 - Progress going on even when Synch view is closed
Summary: Progress going on even when Synch view is closed
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P1 critical (vote)
Target Milestone: 3.0 M9   Edit
Assignee: Jean-Michel Lemieux CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 49036 54385 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-12-16 04:56 EST by Dani Megert CLA
Modified: 2004-04-01 23:04 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2003-12-16 04:56:40 EST 
I20031211

Not sure whether this is a bug but it looks strange to me: after closing the
Synchronize view there's still a running job related to the synch view (seen in
Progress view). When I cancel the job it restarts.

Note: I verified that there's no fast view and no other perspective where the
view could be active.
Comment 1 Jean-Michel Lemieux CLA 2003-12-16 14:28:46 EST 
There may be an event handler job that is not yet finished. But I'll double check.
Comment 2 Jean-Michel Lemieux CLA 2004-02-27 16:18:32 EST 
This is a reminder bug to ensure that participants are disposed when the view is
closed. They used to be kept around to keep the sync sets updated. But this
should no longer be the case.

It's actually pretty important that we ensure resources are freed when sync view
is closed.
Comment 3 Jean-Michel Lemieux CLA 2004-03-15 17:17:47 EST 
*** Bug 49036 has been marked as a duplicate of this bug. ***
Comment 4 Jean-Michel Lemieux CLA 2004-03-15 17:18:39 EST 
This is actually pretty critical. Must fix for M8.
Comment 5 Jean-Michel Lemieux CLA 2004-03-19 08:43:46 EST 
*** Bug 54385 has been marked as a duplicate of this bug. ***
Comment 6 Jean-Michel Lemieux CLA 2004-03-22 10:04:58 EST 
The fix is a bit risky to apply now. Will defer until M8 is declared
Comment 7 Jean-Michel Lemieux CLA 2004-04-01 23:04:14 EST 
So the original bug is actually not a bug - the synchronize schedule isn't
linked with the synchronize view. The results are shown there, but the scheduled
synchronize will still run if the view is closed.

But this PR did remind me that I had to review our instantiation and disposing
of synchronize participants. I've fixed up the instantiation and disposing of
participants and allow more aggressive lazy initialization of participants.