487943 – Retire DefaultContentProvider now we have default methods in IContentProvider

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 487943 - Retire DefaultContentProvider now we have default methods in IContentProvider

Summary: Retire DefaultContentProvider now we have default methods in IContentProvider

Status:	VERIFIED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.5
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.6 M6
Assignee:	Lars Vogel
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:	488057
Blocks:
	Show dependency tree

Reported:	2016-02-17 09:46 EST by Lars Vogel
Modified:	2018-12-04 14:27 EST (History)
CC List:	4 users (show)

See Also:	Gerrit Change Gerrit Change Git Commit Git Commit Gerrit Change Gerrit Change Git Commit Gerrit Change Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2016-02-17 09:46:31 EST

Comment 1 Eclipse Genie

2016-02-17 09:54:23 EST

New Gerrit change created: https://git.eclipse.org/r/66746

Comment 2 Eclipse Genie

2016-02-17 14:33:38 EST

New Gerrit change created: https://git.eclipse.org/r/66764

Comment 3 Eclipse Genie

2016-02-17 14:56:55 EST

Gerrit change https://git.eclipse.org/r/66746 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=13249c4bebcffe685bb31ff9d09e4425b9ab3b43

Comment 4 Eclipse Genie

2016-02-17 14:57:37 EST

Gerrit change https://git.eclipse.org/r/66764 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=1af60f922535b33cc683b6525cdbb3f28ae88dfe

Comment 5 Dani Megert

2016-02-18 02:46:56 EST

Why don't you do this in two single changes, one for pde.ui and one for pde.ua?

Comment 6 Lars Vogel

2016-02-18 04:03:11 EST

(In reply to Dani Megert from comment #5)
> Why don't you do this in two single changes, one for pde.ui and one for
> pde.ua?

I personally try to squeeze in every day a little time for code cleanup. Would be nice to put away a bigger block of time for cleanup per day but that is not always possible.

Comment 7 Dani Megert

2016-02-18 04:44:55 EST

(In reply to Lars Vogel from comment #6)
> (In reply to Dani Megert from comment #5)
> > Why don't you do this in two single changes, one for pde.ui and one for
> > pde.ua?
> 
> I personally try to squeeze in every day a little time for code cleanup.
> Would be nice to put away a bigger block of time for cleanup per day but
> that is not always possible.

Sure, I completely understand that, but you could still update the single Gerrit change each time/day and then submit it when done.

Comment 8 Eclipse Genie

2016-02-18 07:49:14 EST

New Gerrit change created: https://git.eclipse.org/r/66805

Comment 9 Eclipse Genie

2016-02-18 07:49:16 EST

New Gerrit change created: https://git.eclipse.org/r/66804

Comment 10 Eclipse Genie

2016-02-18 14:25:27 EST

Gerrit change https://git.eclipse.org/r/66804 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=91226127ab71b4f41d8e9215144221ae6bd7f31b

Comment 11 Eclipse Genie

2016-02-18 15:11:06 EST

New Gerrit change created: https://git.eclipse.org/r/66863

Comment 12 Eclipse Genie

2016-02-19 05:38:27 EST

Gerrit change https://git.eclipse.org/r/66863 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=f85dca91d48d16b90f3817903249245be95cb349

Comment 13 Eclipse Genie

2016-02-19 05:55:29 EST

Gerrit change https://git.eclipse.org/r/66805 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=5dfb7d8e2cdec286c577bac270cfb4337c2dfa1a

Comment 14 Lars Vogel

2016-02-19 05:55:48 EST

Bye bye DefaultContentProvider.

Comment 15 Vikas Chandra

2016-03-16 02:55:01 EDT

verified by code inspection