487723 – Enable build of all examples for platform.ui

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 487723 - Enable build of all examples for platform.ui

Summary: Enable build of all examples for platform.ui

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.4
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.6 M7
Assignee:	Lars Vogel
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	420078
	Show dependency tree

Reported:	2016-02-12 06:07 EST by Lars Vogel
Modified:	2016-04-14 14:37 EDT (History)
CC List:	4 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2016-02-12 06:07:51 EST

Our master pom contains some example projects but not all. I suggest we include them all (if they compile).

For example jface.snippets are not included in the build and this should IMHO definitely be include to validate that we are not breaking something.

Comment 1 Eclipse Genie

2016-03-29 07:17:27 EDT

New Gerrit change created: https://git.eclipse.org/r/69416

Comment 2 Eclipse Genie

2016-04-12 12:45:05 EDT

Gerrit change https://git.eclipse.org/r/69416 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ae47d321b59f989f6b7aef42c12b09ee51aaaa86

Comment 3 Lars Vogel

2016-04-12 13:00:20 EDT

Build enabled, leaving open to fix any additional build warnings tomorrow.

Comment 4 Eclipse Genie

2016-04-14 14:24:36 EDT

New Gerrit change created: https://git.eclipse.org/r/70694

Comment 5 Mat Booth

2016-04-14 14:25:42 EDT

Hi Lars, this change caused the "dirt report" to increase in size:

http://download.eclipse.org/eclipse/downloads/drops4/N20160413-2000/testresults/html/org.eclipse.releng.tests_ep46N-unit-lin64_linux.gtk.x86_64_8.0.html

Please consider applying this additional patch:

(In reply to Eclipse Genie from comment #4)
> New Gerrit change created: https://git.eclipse.org/r/70694

Comment 6 Eclipse Genie

2016-04-14 14:37:35 EDT

Gerrit change https://git.eclipse.org/r/70694 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f6875a895035d8e2c8d287116179188d3f7e8da7

Comment 7 Lars Vogel

2016-04-14 14:37:42 EDT

(In reply to Mat Booth from comment #5)
> Hi Lars, this change caused the "dirt report" to increase in size:
> 
> http://download.eclipse.org/eclipse/downloads/drops4/N20160413-2000/
> testresults/html/org.eclipse.releng.tests_ep46N-unit-lin64_linux.gtk.
> x86_64_8.0.html
> 
> Please consider applying this additional patch:
> 
> (In reply to Eclipse Genie from comment #4)
> > New Gerrit change created: https://git.eclipse.org/r/70694

Thanks