This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 486647 - [EditorMgmt] Use Text Editor Strategy as default for not associated file extensions
Summary: [EditorMgmt] Use Text Editor Strategy as default for not associated file exte...
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 90292
Blocks:
  Show dependency tree
 
Reported: 2016-01-27 08:51 EST by Lars Vogel CLA
Modified: 2016-05-13 02:49 EDT (History)
13 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2016-01-27 08:51:01 EST
+++ This bug was initially created as a clone of Bug #90292 +++

Bug 90292 introduced different strategies for selecting the editor. I suggest to use the "Text Editor" as default, using the System Editor as default (as before the solution in Bug 90292) is IMHO a bad choice.
Comment 1 Dani Megert CLA 2016-01-27 08:57:12 EST
(In reply to Lars Vogel from comment #0)
> +++ This bug was initially created as a clone of Bug #90292 +++
> 
> Bug 90292 introduced different strategies for selecting the editor. I
> suggest to use the "Text Editor" as default, using the System Editor as
> default (as before the solution in Bug 90292) is IMHO a bad choice.

That would be very bad. It would open e.g. GIFs in the Text Editor.
Comment 2 Andrey Loskutov CLA 2016-01-27 08:58:52 EST
Few points:
* Windows "enterprise" users expect they xls files to be opened with Excel. Hard to argue against this expectation.
* One can at least try to "guess" the text file type (either by magic byte or whatever API we have in Eclipse, see bug 90292 comment 4) and if we *know* it is text, open text editor.
Comment 3 Lars Vogel CLA 2016-01-27 09:03:10 EST
(In reply to Dani Megert from comment #1)
> That would be very bad. It would open e.g. GIFs in the Text Editor.

True. What about "Ask the User" as new default?
Comment 4 Dani Megert CLA 2016-01-27 09:21:15 EST
(In reply to Lars Vogel from comment #3)
> (In reply to Dani Megert from comment #1)
> > That would be very bad. It would open e.g. GIFs in the Text Editor.
> 
> True. What about "Ask the User" as new default?

Hard question. There are two camps:
- Some do not want that system editors are opened without asking (bug 142228)
- Others expect that files known in the OS will be opened by the corresponding
  editors (current behavior)

I'll bring it up in the next PMC call.
Comment 5 Mickael Istria CLA 2016-01-27 09:44:22 EST
I agree there is no absolutely best solution for everyone, and I tend to believe that among the 3 available strategies, the "System Editor or Text if none" is satisfying in many cases.
A compromise would be to use the "Ask the user" configured to store the assocation by default, and showing the best system editor as default selection if one is found. So people opening .xls file would see the suggestion about Excel, press OK once, and the setting would be stored. On the other hand, people opening a .json file would see the proposal and may decide to use the Eclipse Text editor as default.
Comment 6 Doug Schaefer CLA 2016-01-27 11:10:12 EST
(In reply to Mickael Istria from comment #5)
> I agree there is no absolutely best solution for everyone, and I tend to
> believe that among the 3 available strategies, the "System Editor or Text if
> none" is satisfying in many cases.
> A compromise would be to use the "Ask the user" configured to store the
> assocation by default, and showing the best system editor as default
> selection if one is found. So people opening .xls file would see the
> suggestion about Excel, press OK once, and the setting would be stored. On
> the other hand, people opening a .json file would see the proposal and may
> decide to use the Eclipse Text editor as default.

The only thing that bugs me about this is that often these files are opened in a competing product. Xcode opens many of these file types. I believe the same is true for Visual Studio. That's pretty embarrassing.
Comment 7 Mickael Istria CLA 2016-01-27 11:13:52 EST
(In reply to Doug Schaefer from comment #6)
> The only thing that bugs me about this is that often these files are opened
> in a competing product. Xcode opens many of these file types. I believe the
> same is true for Visual Studio. That's pretty embarrassing.

Well, it's a fair behavior: if Eclipse IDE doesn't support a technology and Visual Studio or XCode does; then Visual Studio or XCode is the best thing for the user, and Eclipse IDE has for mission to do the best recommendation for users.
However, I believe the story you mention drives us to the importance of bug 480176 which is the super-bug above all issues related to unknown types. IMO, it's the only one that should require effort/attention currently.
Comment 8 Dani Megert CLA 2016-02-02 11:24:26 EST
(In reply to Dani Megert from comment #4)
> (In reply to Lars Vogel from comment #3)
> > (In reply to Dani Megert from comment #1)
> > > That would be very bad. It would open e.g. GIFs in the Text Editor.
> > 
> > True. What about "Ask the User" as new default?
> 
> Hard question. There are two camps:
> - Some do not want that system editors are opened without asking (bug 142228)
> - Others expect that files known in the OS will be opened by the
> corresponding
>   editors (current behavior)
> 
> I'll bring it up in the next PMC call.

No plans to change this, see https://wiki.eclipse.org/Eclipse/PMC#Meeting_Minutes
Comment 9 Mickael Istria CLA 2016-02-02 13:03:38 EST
Note that if some would like to have the Text Editor as default in their RCP application/specific IDE package, the choice of the strategy is a regular preference that can be tweaked via plugin_customization.ini.