Community
Participate
Working Groups
In the existing deployment wizard, if the user has a route reserved but not currently used by any application, the host name validation in the deployment wizard page will still flag as error. This means that if the user deploy an application, remove the application without removing the route and tries to deploy the application again, the user cannot reuse the previous route when deploying the same application.
Created attachment 259336 [details] Patch to ClientRequestFactory
Jonathan, is there any noticeable difference in performance with this change?
Created attachment 259339 [details] Patch to host taken detection
I found an issue with the original design of host taken detection, which required me to update my patch. The existing design would delete an existing reserved route (one not reserved by the wizard) if the user entered that route and clicked Validate in the wizard. The wizard should never delete existing routes that it did not reserve. The host taken detection API will now communicate back to calling methods whether or not the route was created (a route does not need to be created if it already exists). RE: performance, I have not noticed any performance difference here: Retrieving routes through the Java client is fairly quick. This patch may in fact save a bit of time as we will not incur a performance delay for the subsequent 'addRoute' and 'deleteRoute' operations that would normally occur here.
Changes looks good to me with some minor comments: 1. typo on method comment of UniqueSubdomain: "getUniqueSubdomai(..." should be "getUniqueSubdomain(..." 2. The new class ValidationResult is not part of the patch. 3. Consider to rename ValidationResult to something for narrow, e.g. HostnameValidationResult since with the method isRouteCreated() as part of the methods, this class most likely cannot be used as a general validation result class. Rename will clarify the usage and scope of that class. 4. Thanks for the assessment on the performance impact. Good to hear that.
Created attachment 259340 [details] Patch to host taken detection
