This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 486124 - [quickfix] Provide fix for no-self-assign
Summary: [quickfix] Provide fix for no-self-assign
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: JS Tools (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 11.0   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-19 11:21 EST by Michael Rennie CLA
Modified: 2016-01-19 12:53 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2016-01-19 11:21:52 EST 
We should provide a quickfix for the no-self-assign rule.

The fix should likely just remove the assignment (since it is superfluous).
Comment 1 Michael Rennie CLA 2016-01-19 12:53:28 EST 
Fix + tests:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e148ff48554cde0b34f17bee0456ad8e455f5b0b

I also provided a second fix to rename the RHS of the assignment (in case the self assign was a typo and the dev just wants to quickly rename it).