Community
Participate
Working Groups
Not sure if this is GTK2 specific issue, I will test it later on GTK3 and Windows. Since some time on 4.6 the "Display" popup which can be opened while debugging via Ctrl+Shift+D does NOT automatically disappear after opening by clicking back into the Java editor. This popup does not have <close> button too, so the only way to close it now is to hit <esc> button. I think the default was and should be just clicking somewhere in the editor, and the popup disappears without any extra keys.
Just checked Eclipse 4.4 and 4.5 (all on GTK2), this is really funny. Eclipse 4.4 does everything as expected: the "display" popup disappears if clicking on the editor *AND* the popup has the [x] close button. Eclipse 4.5 does one thing wrong: the "display" popup disappears if clicking on the editor *BUT* the popup does NOT have the [x] close button. Eclipse 4.6 does both things wrong: the "display" popup does NOT disappear if clicking on the editor *AND* the popup does NOT have the [x] close button.
Thanks Andrey for filing this, I have been intending to do so for a while ... The same applies to similar popups, too. From the top of my head I recall at least the value popup from Force Return. (May be the same implementation as "display"). The isssue is aggravated by the fact, that after the customary click into editor you first have to give focus back to the popup before Esc has any effect.
This seem to be GTK specific issue (affects both 2/3 versions), Windows works. I've reproduced this now on GTK3 too, my build is 4.6.0.I20151229-0800. $rpm -q gtk2 gtk2-2.24.28-1.fc21.x86_64 $ rpm -q gtk3 gtk3-3.14.15-1.fc21.x86_64 Alex, Eric: do you think is is SWT specific, should we move this to SWT? I wonder if there were any shell/window related changed in 4.6? Something focus related?
This is a regression from the fix for bug 466500. Reverting commit https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ddcfd1f3efd70591480e6c053946618ef6696104 fixes the issue. I don't know which one is worse, for me they are both ugly.
What's funny about this problem, like Andrey said, is that this bug and the alternative are both pretty bad. If it's possible to restore the close button to the title bar, what do you think about undoing the revert? Having the Quick Outline, Type Hierarchy, etc. disappear when you click the title bar or try to re-size it is pretty annoying. This way you could close the Display window easily with the close button/"X" in the title bar, and still allow the Quick Outline, Type Hierarchy, etc. to not be buggy.
(In reply to Eric Williams from comment #5) > What's funny about this problem, like Andrey said, is that this bug and the > alternative are both pretty bad. > > If it's possible to restore the close button to the title bar, what do you > think about undoing the revert? Having the Quick Outline, Type Hierarchy, > etc. disappear when you click the title bar or try to re-size it is pretty > annoying. I think in the direction to give a "master" shell to the PopupDialog (either constructor or extra setter) and *do* close the popup if the master shell is active and has focus. This way we fix this bug and do not revert bugfix for another one. WDYT?
(In reply to Andrey Loskutov from comment #6) > I think in the direction to give a "master" shell to the PopupDialog (either > constructor or extra setter) and *do* close the popup if the master shell is > active and has focus. This way we fix this bug and do not revert bugfix for > another one. WDYT? That sounds perfectly reasonable to me!
New Gerrit change created: https://git.eclipse.org/r/64307
(In reply to Eclipse Genie from comment #8) > New Gerrit change created: https://git.eclipse.org/r/64307 This fixes the current bug for me without breaking the fix for bug 466500.
Gerrit change https://git.eclipse.org/r/64307 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=709f5676c36bbe432d299c874449101035f4dbe6
@Stephan: the fix will be available in the next nightly platform build.
