Community
Participate
Working Groups
Bug 485259 solved most of the performance issue in the properties view by caching the computation of advices for a given element type. However, we still notice some delays in some cases Some advices take a lot of time to build simple commands, by e.g. navigating the entire model to find references, or doing computation for profiles that are not applied (e.g. Looking for SysML Stereotypes when SysML is not applied). This is especially visible with SysML, as it is installed by default in Papyrus, but other advices may be involved (Including UML ones). In general, we should ensure that: - Advices for a given language are involved only if the language is applied (e.g. Profiles) - Advices always use the CacheAdapter when looking for incoming references/usages (Navigating the resource set doesn't scale) - ... This is critical for performances, as Advices can be involved everywhere (Properties view, diagram, context menus...) and can quickly kill performances when under-optimized
https://git.eclipse.org/r/#/c/63705/ fixes some SysML Advices Tests still running locally in parallel to the Gerrit build, but since the SysML Tests currently contain a lot of failures it may be difficult to guarantee the result (Especially since I'm not sure how the SysML ConnectorEnds/PropertyPath should behave)
I've verified that the new CacheAdapter-based method returns the same results as the previous (slower) implementation (Without the duplicates). I will push the contribution to Neon to let Hudson give a verdict on the test results (I cannot properly check the test results locally)
Cherry pick to Mars: https://git.eclipse.org/r/#/c/63728/ I'm waiting for the test results on Hudson/Master before going further
The contribution didn't break any new test I've merged https://git.eclipse.org/r/#/c/63728/ to Mars as well
