This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 484418 - Need to improve js tools (npm / bower) launch
Summary: Need to improve js tools (npm / bower) launch
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.7   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.8 M5   Edit
Assignee: Ilya Buziuk CLA
QA Contact: Victor Rubezhny CLA
URL:
Whiteboard: RHT
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-15 12:27 EST by Ilya Buziuk CLA
Modified: 2015-12-25 12:00 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Buziuk CLA 2015-12-15 12:27:54 EST
For now npm / bower is launched via node. Basically, this was done due to the fact that on Mac Os launched from desktop node PATH var not available:
 {quote}
env: node: No such file or directory
 {quote}
In order to handle it, it was suggested to launch npm / bower tools via node and have a preference for each tool. However, on thym project more elegant solution was found - execute the given command and returns a handle to the process. 
More details can be found here:
- https://github.com/gorkem/thym/blob/use_cli/plugins/org.eclipse.thym.core/src/org/eclipse/thym/core/internal/cordova/CordovaCLI.java#
- https://github.com/gorkem/thym/blob/use_cli/plugins/org.eclipse.thym.core/src/org/eclipse/thym/core/internal/util/ExternalProcessUtility.java

Basically, this approach kills two birds with one stone:
1. No mac os Path issue
2. No need to have preferences for node / npm / bower

Also, it will be quite easy to provide cheatsheets for this tools which will include sets of commands

The plan is:
- reimplement the launch process that will be generic for both jsdt and thym (gulp / grunt tools in future)
- remove irrelevant code with preferences, detectors etc

All external tool functionality will be embedded in a plugin which provides ability to make CLI calls across all platforms
Comment 1 Eclipse Genie CLA 2015-12-22 09:48:44 EST
New Gerrit change created: https://git.eclipse.org/r/63156