Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 483097 - [GTK3.16+] gtk_widget_override_color is deprecated
Summary: [GTK3.16+] gtk_widget_override_color is deprecated
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.8 M1   Edit
Assignee: Eric Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 470165 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-11-26 09:23 EST by Eric Williams CLA
Modified: 2017-06-28 09:52 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Williams CLA 2015-11-26 09:23:55 EST 
As of GTK3.16, calls to gtk_widget_override_color are not guaranteed to work.

I have a patch in the works that converts set/get foreground methods to use CSS for GTK3.16 and greater. This is the proper GTK way as CSS theming is the direction the GTK team is taking.

For more info see: https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-override-color
Comment 1 Eclipse Genie CLA 2015-12-01 15:57:25 EST 
New Gerrit change created: https://git.eclipse.org/r/61701
Comment 2 Eric Williams CLA 2016-03-15 09:48:42 EDT 
Moving to M7 as this patch is *almost* done, just needs a few finishing touches. Not going to push this big a change right before M6.
Comment 4 Eric Williams CLA 2016-04-01 10:15:21 EDT 
(In reply to Eclipse Genie from comment #3)
> Gerrit change https://git.eclipse.org/r/61701 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=429cd4e4ecbd8dbfaed902ac7f054c2adda254fe

Patch is in master now. Foregrounds and backgrounds are 100% GTK CSS compatible now for GTK3.16+.
Comment 5 Alexander Kurtakov CLA 2016-04-02 10:30:01 EDT 
*** Bug 470165 has been marked as a duplicate of this bug. ***
Comment 6 Sravan Kumar Lakkimsetti CLA 2016-04-27 05:11:54 EDT 
Verified code on Ubuntu Mate 16.04 with I20160426-1615
Comment 7 Eclipse Genie CLA 2017-06-27 12:15:58 EDT 
New Gerrit change created: https://git.eclipse.org/r/100157
Comment 9 Eric Williams CLA 2017-06-27 12:23:23 EDT 
(In reply to Eclipse Genie from comment #8)
> Gerrit change https://git.eclipse.org/r/100157 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=a1c0d04e0979e30a3b0fd5ac1090fbc42c7a72ac

Updated the regex used to parse the GTK CSS for foreground colors. Now works with rgba corner cases instead of just rgb.