This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 483010 - [eslint] Provide rule for unecessary non-nls messages
Summary: [eslint] Provide rule for unecessary non-nls messages
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: JS Tools (show other bugs)
Version: 10.0   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 11.0   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-25 09:59 EST by Curtis Windatt CLA
Modified: 2015-12-01 17:38 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2015-11-25 09:59:22 EST 
We have a rule for missing-nls.  As we add more cases to this rule there are additional cases where spurious non-nls messages are left in the code.  We should have a rule to find these cases.
Comment 1 Curtis Windatt CLA 2015-12-01 17:38:45 EST 
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0a7c70c458dec7470c7a5da90db8426f127ebcf7
Fixed in master

Added new rule
Merged logic to count literals on source lines with missing-nls rule so only runs once
Created quick fix for the rule
Added tests for both the rule and the quick fix
Rule defaults to off but can be turned on in settings