Community
Participate
Working Groups
We should update the the latest version to get the latest in ES6 scoping. There will be a bit more work this time around as we have to convert the es6 module code in escope to AMD.
CQ is here: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=10405
I opened the CQ to just jump to EScope 3.6.0: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=11163
The CQ is approved - but 3.6.0 has other node dependencies that we need to remove. Then we can build it using the webpack build file I placed in master.
The offending references are: 1. assert in referencer.js 2. es6-map and assert in scope.js 3. es6-weak-map and assert in scope-manager.js
Created attachment 261703 [details] built 3.6.0 Here is a built version of 3.6.0 with the offending node deps removed. We need to test this, because it is using the globally defined Map and WeakMap - which according to the compat tables, all of the browser now have (and have had for a while)
*** Bug 493587 has been marked as a duplicate of this bug. ***
(In reply to Michael Rennie from comment #5) > Created attachment 261703 [details] > built 3.6.0 > > Here is a built version of 3.6.0 with the offending node deps removed. > > We need to test this, because it is using the globally defined Map and > WeakMap - which according to the compat tables, all of the browser now have > (and have had for a while) I did find one issue - the new version of escope is throwy - meaning if you have an import statement and it is not in es6 + "module" mode it throws an exception causing eslint to not lint the rest of the file. My suggestion would be to just get rid of the throw statement from escope
Pushed the new version into master: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f75161608e5f229b908d8f1b945005ab808eb817 Will leave this bug open until we test in new builds
Support looks good after additional testing in the new builds. Closing fixed.
