Community
Participate
Working Groups
It has been a while since we updated ESLint. The library is now at version 1.9.0. There are many updates we can make use of: 1. plugins - we could get rid of our edits to the lib and push all our 'orion addons' into a plugin 2. new API that can take infos from a AST (we no longer have to make changes to the API to use it) 3. fixes - rules can now provide the code to use to fix the problem reported - we might be able to hook this up to our quick fixes to provide 'fix all problems of this type' and get rid of the command-based quick fixes. The CQ is here: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=10397 I also asked if we could re-examine using the stock rule set from eslint.
Not sure whether a re-read of Bug 467903 is useful.
ESLint now makes use of the 'globals' package (really just a JSON file), I have opened a CQ for that as well: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=10400
I'll provide a patch for this one.
I will adopt the new globals version at the same time. See https://dev.eclipse.org/ipzilla/show_bug.cgi?id=10400
Created attachment 258289 [details] Proposed patch This patch also includes the new rule for no-mixes-spaces-and-tabs.
Created attachment 258290 [details] Proposed patch New version with html file updated.
Merged with: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=d0bf46fae8044c58037329b8f77765a4faad51cf All tests pass. With this commit we are not directly consuming the rules from ESLint. We can do that work in bug 467903
