Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 482024 - ExpandableComposite layout issues for wrap or oversized text controls
Summary: ExpandableComposite layout issues for wrap or oversized text controls
Status: CLOSED DUPLICATE of bug 196692
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-12 10:58 EST by Elena Laskavaia CLA
Modified: 2017-05-17 09:53 EDT (History)
3 users (show)

See Also:


Attachments
ScreenShot Examples 1-6 (before and after fix) (143.19 KB, image/png)
2015-11-12 10:58 EST, Elena Laskavaia CLA
no flags Details
Screenshot Example 7-10 (before and after fix) (75.32 KB, image/png)
2015-11-12 10:58 EST, Elena Laskavaia CLA
no flags Details
ScreenShot Examples 1-6 Link (before and after fix) (144.54 KB, image/png)
2015-11-12 11:14 EST, Elena Laskavaia CLA
no flags Details
Test Code (9.13 KB, text/java)
2015-11-12 11:20 EST, Elena Laskavaia CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Elena Laskavaia CLA 2015-11-12 10:58:05 EST
Created attachment 257902 [details]
ScreenShot Examples 1-6 (before and after fix)

There are multiple issues in layout for Expandable composite when it deals with custom text controls, specifically when text control designed to fill/grab or when it does not fit in client area

Here is list of specific issues (also demonstrated in attached picture)

* With no title style text control never given proper hint to fit, so none of them fit properly including simple label or control with wrap layouts
(example 1, 2)
* Right justifier control is not given proper bounds and overflows, so its painted under the label and toggle and CUT off from the begging. From my understanding of layouts control should not be cut off from the begging even it is right justified (example 3,5,6)
* If text control considered to be "no wrap" bounds are not set properly, hint is not given and layout gives unreasonable width for text label (5 pixels), which is a) not enough to even render one letter b) looks horrible (example 3,4,6). Also Bug 368861 covers part about setting bounds in this case.
Controls that would wish to "fill" the space are not given this opportunity since hint is not given for computeSize (see examples 7-10)
Comment 1 Elena Laskavaia CLA 2015-11-12 10:58:38 EST
Created attachment 257903 [details]
Screenshot Example 7-10 (before and after fix)
Comment 2 Elena Laskavaia CLA 2015-11-12 11:14:59 EST
Created attachment 257904 [details]
ScreenShot Examples 1-6 Link (before and after fix)

And this is example when label control is Link (vs Label) (i.e. FOCUS_TITLE
vs NO_TITLE_FOCUS_BOX)
Comment 3 Elena Laskavaia CLA 2015-11-12 11:20:39 EST
Created attachment 257905 [details]
Test Code

This is not really snipped because it is huge, this is the test that I used to generate the screenshots
Comment 4 Lars Vogel CLA 2015-11-12 11:27:00 EST
Simon, please review
Comment 5 Elena Laskavaia CLA 2015-11-12 14:11:02 EST
I assigned it to myself because I have a fix for this.
Btw Bug 368861 I mention above is not related as it appears later since
it is about client not text client.
Comment 6 Eclipse Genie CLA 2015-11-12 14:23:03 EST
New Gerrit change created: https://git.eclipse.org/r/60264
Comment 7 Stefan Xenos CLA 2016-01-22 21:28:59 EST
Possibly related to bug 196692.
Comment 8 Stefan Xenos CLA 2016-01-22 21:34:54 EST
Actually, I think this is a dupe of bug 196692.
Comment 9 Stefan Xenos CLA 2016-01-22 21:37:53 EST

*** This bug has been marked as a duplicate of bug 196692 ***