Community
Participate
Working Groups
Created attachment 257902 [details] ScreenShot Examples 1-6 (before and after fix) There are multiple issues in layout for Expandable composite when it deals with custom text controls, specifically when text control designed to fill/grab or when it does not fit in client area Here is list of specific issues (also demonstrated in attached picture) * With no title style text control never given proper hint to fit, so none of them fit properly including simple label or control with wrap layouts (example 1, 2) * Right justifier control is not given proper bounds and overflows, so its painted under the label and toggle and CUT off from the begging. From my understanding of layouts control should not be cut off from the begging even it is right justified (example 3,5,6) * If text control considered to be "no wrap" bounds are not set properly, hint is not given and layout gives unreasonable width for text label (5 pixels), which is a) not enough to even render one letter b) looks horrible (example 3,4,6). Also Bug 368861 covers part about setting bounds in this case. Controls that would wish to "fill" the space are not given this opportunity since hint is not given for computeSize (see examples 7-10)
Created attachment 257903 [details] Screenshot Example 7-10 (before and after fix)
Created attachment 257904 [details] ScreenShot Examples 1-6 Link (before and after fix) And this is example when label control is Link (vs Label) (i.e. FOCUS_TITLE vs NO_TITLE_FOCUS_BOX)
Created attachment 257905 [details] Test Code This is not really snipped because it is huge, this is the test that I used to generate the screenshots
Simon, please review
I assigned it to myself because I have a fix for this. Btw Bug 368861 I mention above is not related as it appears later since it is about client not text client.
New Gerrit change created: https://git.eclipse.org/r/60264
Possibly related to bug 196692.
Actually, I think this is a dupe of bug 196692.
*** This bug has been marked as a duplicate of bug 196692 ***
Gerrit change https://git.eclipse.org/r/60264 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e09eb0f702ecafa189017550bb8f1ca0edddd125