Community
Participate
Working Groups
In order to make contribution easier to submit and review, the webtools.sourceediting repository should be moved to Gerrit. The webtools.sourceediting.tests repository should remained untouched as there are short/mid-term plans to merge it into webtools.sourceediting. This webtools.sourceediting.tests repository will be deprecated after that. The strategy to choose would be that: * Anyone can submit patch via Gerrit review * Committers are also allowed to push directly to the repository, using Gerrit remote URL * The "regular" URL should be kept as a read-only one as possible (to avoid breaking older builds relying on it) For committers, the change would be to: 1. Make sure Gerrit knows your SSH key by adding it to https://git.eclipse.org/r/#/settings/ssh-keys 2. Change remote URL for webtools.srouceediting to ssh://yourUserId@git.eclipse.org:29418/sourceediting/webtools.sourceediting (note that there are alternatives to use HTTPS if you don't like SSH: https://wiki.eclipse.org/Gerrit#Git_over_HTTPS ).
Hi Mickael, Thanks for opening this defect. We also have https://bugs.eclipse.org/bugs/show_bug.cgi?id=480382 open to track moving over to Gerrit. Alina has been looking at this work as well, in particular in regards to merging tests into source editing off the bat. But I like the idea of getting over to Gerrit first and then trying to merge our tests that way.
Why moving the repo and not only enabling it for Gerrit? That is what we did in platform. It can be easily down by webmaster.
@Nick: ok, I didn't notice the previous bug. Feel free to close this one as DUPLICATE then. @Lars: the idea with moving repo to Gerrit instead of enabling Gerrit additionally to regular Git is that everyone who wants to contribute would have to use the same remote URL. This removes some confusion and makes the contribution process more consistent betweeen committers and 1-time contributors. Also, on longer-term, plain Git may be abandonned: See bug #452549 for details.
The sourceediting repo is moved to Gerrit now. What do we need to do to enable a Hudson Job for validating the contributions made through Gerrit for sourceediting? After the sourceediting.tests repo is merged into sourceediting repository and maven project configuration is changed in order to reflect this change the project can be built by the following maven command: mvn clean install -DskipTests=true -Pbuild-individual-bundles and JUnit tests can be started with: mvn clean varify -Pbuild-individual-bundles As of today build and tests can be performed with success on my local environment.
You'll need to find someone who has permissions to create jobs on WebTools HIPP instance. Unfortunately, I don't have those. My recommendation for setting up such job for sourceediting would be to create the new sourceediting-gerrit job as a clone of jsdt-gerrit and to simply replace "jsdt" by "sourceediting" in the configuration. It should work immediately.
(In reply to Mickael Istria from comment #5) > You'll need to find someone who has permissions to create jobs on WebTools > HIPP instance. Unfortunately, I don't have those. > My recommendation for setting up such job for sourceediting would be to > create the new sourceediting-gerrit job as a clone of jsdt-gerrit and to > simply replace "jsdt" by "sourceediting" in the configuration. It should > work immediately. @Victor: did you manage to get a build validating incoming Hudson reviews for sourceediting?
(In reply to Mickael Istria from comment #6) > (In reply to Mickael Istria from comment #5) > > You'll need to find someone who has permissions to create jobs on WebTools > > HIPP instance. Unfortunately, I don't have those. > > My recommendation for setting up such job for sourceediting would be to > > create the new sourceediting-gerrit job as a clone of jsdt-gerrit and to > > simply replace "jsdt" by "sourceediting" in the configuration. It should > > work immediately. > > @Victor: did you manage to get a build validating incoming Hudson reviews > for sourceediting? @Mickael, no, I didn't. Thanks for reminding. I don't know who is able to do it, so I've created: Bug 485786 - [job] create new Webtools SourceEditing job for Gerrit verify
@Mickael, could you please look at https://bugs.eclipse.org/bugs/show_bug.cgi?id=485786#c1 - Mikael Barbero asks us to clarify the requirements for sourceediting gerrit job. My description may be unclear or not correct, so could you please look at and may be add some clarification on what we need.
I created the job: https://hudson.eclipse.org/webtools/job/sourceediting-gerrit/ Just need someone to test and confirm it works.
Thanks to Thanh Ha, now we have the job https://hudson.eclipse.org/webtools/job/sourceediting-gerrit/ is created and working correctly: - it's being triggered by a Gerrit change - it executes JUnit tests for sourceediting repository. We've tested it manually (see: https://hudson.eclipse.org/webtools/job/sourceediting-gerrit/1/) as well as by pushing a change into Gerrit (see: https://hudson.eclipse.org/webtools/job/sourceediting-gerrit/2/) - all worked fine for us. As such I suppose that the move of webtools.sourceediting repository to Gerrit is done.
Seems like sourceediting now has all the best infrastructure.
