Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 480612 - [1.9] Code completion support for module-info
Summary: [1.9] Code completion support for module-info
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: BETA J9   Edit
Assignee: Manoj N Palat CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 486988 506482 509050 518618
Blocks: 457413 482260 487779
  Show dependency tree
 
Reported: 2015-10-26 03:54 EDT by Jay Arthanareeswaran CLA
Modified: 2017-10-09 04:20 EDT (History)
5 users (show)

See Also:

Attachments
work in progress -patch (67.30 KB, patch)
2016-02-16 11:51 EST, Manoj N Palat CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Arthanareeswaran CLA 2015-10-26 03:54:45 EDT 
When the parser changes for module-info is complete (bug 479610), we should be in a position to consider the completion and selection support for the same.
Comment 1 Manoj N Palat CLA 2016-02-13 00:12:55 EST 
bug 486988 - it is easier to address that bug in whole with the basic framework in place first - hence taking this bug on me.
filed bug 487779 addresses the jdt.ui part
Comment 2 Manoj N Palat CLA 2016-02-16 11:51:14 EST 
Created attachment 259774 [details]
work in progress -patch
Comment 3 Stephan Herrmann CLA 2017-09-02 17:17:34 EDT 
I think much of this is working already, isn't it?

Do we have a good picture of what's still missing?
Comment 4 Manoj N Palat CLA 2017-09-04 23:19:07 EDT 
(In reply to Stephan Herrmann from comment #3)
> I think much of this is working already, isn't it?

Yes. most of the planned ones are in.

> Do we have a good picture of what's still missing?

Yes. second para of bug 509050 comment 5 summarises the same (reproduced below:)

What is not available/planned:
 - keywords module, open (as in "open module"), transitive/static in requires.
 - the proposed annotations on modules - essentially anything outside module body.

Another item I had in mind was the completion of module name, but then we donot have a general rule yet as to what could be the module name - the best bet was the project name - in the initial patch this was included then later decided not to give completion on that unless there is a consensus. So this can also be taken up later.
Comment 5 Manoj N Palat CLA 2017-10-09 04:20:45 EDT 
Resolving the top level bug - specific bugs to be addressed individually.