Community
Participate
Working Groups
Created attachment 257334 [details] Images of the bug Hi, sorry my english. After updated to Eclipse Mars.1, the path of change files doenst show when i want commit to master. See details in atached file. This problems dont ocurrs in Version: Mars Release (4.5.0) - (check the print). Only in Mar.1 . The version of EGit (4.1.x) is the same in the both version of eclipse. I Use GitLab. Thanks.
*** This bug has been marked as a duplicate of bug 466499 ***
We've got second bug with same issue (bug 480292) on 4.5.1 which looks like a duplicate of bug 466499, but according to bug 466499 comment 26 it should be merged to 4.5.1, so I'm reopening to investigate.
*** Bug 480292 has been marked as a duplicate of this bug. ***
Renan, please attach here details about your operating system, desktop and gtk3 version. Thanks.
Same issue on Mars.1 Release (4.5.1) Build id: 20150924-1200 with org.eclipse.swt.gtk.linux.x86_64 Version 3.104.1.v20150825-0743 and org.eclipse.egit.ui Version 4.0.3.201509231615-r on Linux Mint Cinnamon 64 bit (See Bug 480292 comment 1) Please let me know if you need any further information.
Please post your gtk3 version. rpm -q gtk3 or dpkg -l | grep libgtk-3 or Help -> About -> Installation Details -> Configuration" dialog - search for the "org.eclipse.swt.internal.gtk.version" property.
dpkg -l | grep libgtk-3 -> 3.10.8~8+qiana and from the configuration: -> org.eclipse.swt.internal.gtk.version=3.10.8
I can't reproduce this on Neon Nightly 20151001. I think the issue here is the version of Gtk you are using. If you'll note, the fixes in bug 466499 are guarded by a version check for versions greater than Gtk3.13. Since you are using Gtk3.10 I imagine this would be causing the problem. Would it be possible to update the version of Gtk3 on your system?
I have the same issue. The latest GTK version on the current Linux Mint 17.x distro is 3.10.8~8+qiana, so upgrading that is not easy without opening a can of dependency worms.
And Linux Mint 17.x is the long term support version, which will be supported until April 2019. Many users may prefer to stay on the LTS version for stability.
*** Bug 488103 has been marked as a duplicate of this bug. ***
I can't reproduce the issue on GTK 3.10.8 (compiled from source). The issue described in bug 466499 occurs only on GTK >= 3.14. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=466499#c5. I don't have Mint 17.x to test, but the issue doesn't happen on GTK 3.10.8.
The Bug is still there after the update to 4.5.2. Are there any plans to solve this? It's one of the major show stopper to use Mars.
You can use the follow workaround while there is not solution: Add this to your eclipse.ini file: --launcher.GTK_version 2 The option --launcher.GTK_version should be before --launcher.appendVmargs (Thanks Bernard Arjan Draaisma (bendraaisma@gmail.com))
Renan, Daniel, can you confirm exactly which version of Linux Mint you have? 17.3?
The workaround works for the empty paths on the commit dialogue. If you double click a file there, to see the changes, the compare dialogue opens with estimated 1000x500px. But it's broken... http://prnt.sc/acyio4 Also a Problem that is there since Mars Release... (4.5, 4.5.1, 4.5.2)
(In reply to Nabor Gilgalad from comment #16) > The workaround works for the empty paths on the commit dialogue. > > If you double click a file there, to see the changes, the compare dialogue > opens with estimated 1000x500px. But it's broken... > > http://prnt.sc/acyio4 This is a separate bug, see bug 471094.
(In reply to Marc-Andre Laperle from comment #15) > Renan, Daniel, can you confirm exactly which version of Linux Mint you have? > 17.3? I am using Qiana (17.0)
(In reply to Marc-Andre Laperle from comment #15) > Renan, Daniel, can you confirm exactly which version of Linux Mint you have? > 17.3? I'm using 17.3 - Rosa. I had the some bug in the 17.2 - Rafaela. I reproduce the some bug in 2 computers (Mint 17.3).
(In reply to Renan Furtado from comment #19) > (In reply to Marc-Andre Laperle from comment #15) > > Renan, Daniel, can you confirm exactly which version of Linux Mint you have? > > 17.3? > > I'm using 17.3 - Rosa. I had the some bug in the 17.2 - Rafaela. > I reproduce the some bug in 2 computers (Mint 17.3). Thanks, I can reproduce it with the latest 4.6-I build. I'll investigate a bit. Could be a theme specific issue or a patch applied to this GTK.
Created attachment 260272 [details] Controls theme setting If I change the Controls theme from Mint-x to Adwaita then it works correctly. I'm not sure what the root cause is yet. I attached a screenshot of the setting to make it easier to find. It could serve as a work around for some.
I can reproduce it on Ubuntu 15.10 with GTK 3.10.8. I modified the Ambiance theme to be able to reproduce it. In gtk-widgets.css, I added this: GtkTreeView { -GtkWidget-focus-line-width: 0; } I seems to be a bug with the handling of focus-line-width when it is set to 0. In later version of GTK it works correctly. I'll bisect to find the commit.
It turns out that the commit in question in GTK was just a version bump to 3.13.1, which means this behavior depends on a version check in SWT. The one that matches this is the one introduced in bug 466499. (In reply to Snjezana Peco from comment #12) > I can't reproduce the issue on GTK 3.10.8 (compiled from source). > The issue described in bug 466499 occurs only on GTK >= 3.14. See > https://bugs.eclipse.org/bugs/show_bug.cgi?id=466499#c5. > > I don't have Mint 17.x to test, but the issue doesn't happen on GTK 3.10.8. I can reproduce it on Ubuntu 15.10 with GTK 3.10.8 by modifying the Ambiance theme. To reproduce, you can copy /usr/share/themes/Ambiance to ~/.themes then edit ~/.themes/Ambiance/gtk-3.0/gtk-widgets.css add GtkTreeView { -GtkWidget-focus-line-width: 0; } **Don't forget to remove it once your done with this bug!** When I modify the SWT Tree code to remove the version check, then it works. --- a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Tree.java +++ b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Tree.java @@ -2726,7 +2726,7 @@ } if (item != null) { if (OS.GTK_IS_CELL_RENDERER_TOGGLE (cell) || - ( (OS.GTK_IS_CELL_RENDERER_PIXBUF (cell) || OS.GTK_VERSION > OS.VERSION(3, 13, 0)) && (columnIndex != 0 || (style & SWT.CHECK) == 0))) { + ( (OS.GTK_IS_CELL_RENDERER_PIXBUF (cell) || OS.GTK3) && (columnIndex != 0 || (style & SWT.CHECK) == 0))) { drawFlags = (int)/*64*/flags; drawState = SWT.FOREGROUND; long /*int*/ [] ptr = new long /*int*/ [1]; Would it be possible to have more information on the original fix that introduced the version check? I understand there was a difference in behavior in the number of rendererRender signals sent (bug 466499 comment 5) but it's not clear to me why and if it would happen in other situations (i.e. when focus-line-width == 0). I saw some commits later in the GTK commit history that removed the use of focus-line-width so perhaps removing the use of focus-line-width (>= 3.14?) and setting focus-line-width to 0 is one and the same code path. In fact, if I go back to GTK 3.4.4 and set focus-line-width to 0, I get the bug and it gets fixed if I remove the version check in SWT. I think at this point it would be better to check what's going on in GTK to really understand what the right fix is.
(In reply to Marc-Andre Laperle from comment #23) > I can reproduce it on Ubuntu 15.10 with GTK 3.10.8 by modifying the Ambiance > theme. To reproduce, you can copy > /usr/share/themes/Ambiance to ~/.themes > then edit ~/.themes/Ambiance/gtk-3.0/gtk-widgets.css > add > GtkTreeView { > -GtkWidget-focus-line-width: 0; > } > > > **Don't forget to remove it once your done with this bug!** > > > When I modify the SWT Tree code to remove the version check, then it works. > > --- a/bundles/org.eclipse.swt/Eclipse > SWT/gtk/org/eclipse/swt/widgets/Tree.java > +++ b/bundles/org.eclipse.swt/Eclipse > SWT/gtk/org/eclipse/swt/widgets/Tree.java > @@ -2726,7 +2726,7 @@ > } > if (item != null) { > if (OS.GTK_IS_CELL_RENDERER_TOGGLE (cell) || > - ( (OS.GTK_IS_CELL_RENDERER_PIXBUF (cell) || OS.GTK_VERSION > > OS.VERSION(3, 13, 0)) && (columnIndex != 0 || (style & SWT.CHECK) == 0))) { > + ( (OS.GTK_IS_CELL_RENDERER_PIXBUF (cell) || OS.GTK3) && (columnIndex != > 0 || (style & SWT.CHECK) == 0))) { > drawFlags = (int)/*64*/flags; > drawState = SWT.FOREGROUND; > long /*int*/ [] ptr = new long /*int*/ [1]; > > I have tried your patch. It introduces a clipping issue on GTK 3.10.8. See the screenshot.
Created attachment 260287 [details] A clipping issue
(In reply to Snjezana Peco from comment #24) > I have tried your patch. It introduces a clipping issue on GTK 3.10.8. > See the screenshot. Hi Snjezana. I'm not suggesting to apply the patch as is, otherwise I will push it to Gerrit. But I thought it would be easier to communicate what I meant. I do not know the right fix but I'm trying the best I can to bring the investigation further :)
I believe this is fixed for quite some time. If anyone still experience it with Oxygen please reopen with details.
