479960 – Remove unnecessary cancellation and done checks for SubMonitor.split in pde

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 479960 - Remove unnecessary cancellation and done checks for SubMonitor.split in pde

Summary: Remove unnecessary cancellation and done checks for SubMonitor.split in pde

Status:	VERIFIED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.5
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.6 M4
Assignee:	Lars Vogel
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:	479950
Blocks:
	Show dependency tree

Reported:	2015-10-16 08:20 EDT by Lars Vogel
Modified:	2015-12-02 10:12 EST (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2015-10-16 08:20:44 EDT

+++ This bug was initially created as a clone of Bug #479950 +++

Comment 1 Eclipse Genie

2015-10-16 08:21:21 EDT

New Gerrit change created: https://git.eclipse.org/r/58319

Comment 2 Lars Vogel

2015-10-16 10:00:11 EDT

Hm PDE seems to be a bit more complex than platform UI. Stefan, can you have a look at the replacement in PDE?

Comment 3 Stefan Xenos

2015-10-17 00:41:54 EDT

Actually, I only did the easy ones in UI. It has some hairy special cases, too. :-(

Comment 4 Eclipse Genie

2015-11-02 04:00:40 EST

Gerrit change https://git.eclipse.org/r/58319 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=197308fec061d70c2265514fd29f282b105279bb

Comment 5 Lars Vogel

2015-12-02 10:12:03 EST

Marking as fixed for M4 even though we can still do much more work here. But I currently have no time to continue this simplification. 

If I find more time in the future, I will open a new bug.

Comment 6 Lars Vogel

2015-12-02 10:12:11 EST