Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 479812 - [refs] Preview page layout puts it outside the editor area
Summary: [refs] Preview page layout puts it outside the editor area
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: JS Tools (show other bugs)
Version: 10.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 10.0   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 471947
  Show dependency tree
 
Reported: 2015-10-15 00:07 EDT by Michael Rennie CLA
Modified: 2015-10-15 08:48 EDT (History)
2 users (show)

See Also:

Attachments
proposed fix (2.32 KB, patch)
2015-10-15 00:11 EDT, Michael Rennie CLA 		no flags Details | Diff
updated patch (3.59 KB, patch)
2015-10-15 00:58 EDT, Michael Rennie CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2015-10-15 00:07:53 EDT 
When you try to replace matches while the view is in grouped mode, there is no preview, just a blank page.
Comment 1 Michael Rennie CLA 2015-10-15 00:11:31 EDT 
Created attachment 257270 [details]
proposed fix

This patch fakes up a file model item for a match in grouped mode allowing it to show a diff for each match.

There are a couple of issues though:

1. the compare pane has bad layout (this happens in all searches, not just refs)
2. if you uncheck all the changes, the 'replace all' button disappears, and no ammount of re-checking brings it back
Comment 2 Michael Rennie CLA 2015-10-15 00:58:35 EDT 
Created attachment 257271 [details]
updated patch

This patch fixes up the layout problems for all search views using the diff preview.

Still haven't figured out the button disappearing problem.
Comment 3 Michael Rennie CLA 2015-10-15 08:46:09 EDT 
Looks like Libing created a new bug for the preview model bits (bug 479852), so I'll make this bug be about the styling of the preview page.