478399 – NPE when fragment without parent ID is merged

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 478399 - NPE when fragment without parent ID is merged

Summary: NPE when fragment without parent ID is merged

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.5
Hardware:	PC Windows NT

Importance:	P3 normal (vote)
Target Milestone:	4.6 M3
Assignee:	Jonas Helming
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:	478400
Blocks:
	Show dependency tree

Reported:	2015-09-25 06:50 EDT by Jonas Helming
Modified:	2015-10-26 05:17 EDT (History)
CC List:	2 users (show)

See Also:	Gerrit Change Git Commit 480610

Attachments
bug fixed (4.60 KB, patch) 2015-10-22 10:18 EDT, Ihor Yatsenko	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonas Helming

2015-09-25 06:50:57 EDT

When a fragment without a prent ID is regeistered, you get a NPW, because there is no check.

java.lang.NullPointerException
	at org.eclipse.e4.ui.model.fragment.impl.StringModelFragmentImpl.merge(StringModelFragmentImpl.java:296)
	at org.eclipse.e4.ui.internal.workbench.ModelAssembler.processFragment(ModelAssembler.java:192)
	at org.eclipse.e4.ui.internal.workbench.ModelAssembler.processFragments(ModelAssembler.java:103)
	at org.eclipse.e4.ui.internal.workbench.ModelAssembler.processModel(ModelAssembler.java:83)

Comment 1 Lars Vogel

2015-10-15 09:53:24 EDT

Jonas, are you still planning to fix this for M3?

Comment 2 Eclipse Genie

2015-10-16 05:08:48 EDT

New Gerrit change created: https://git.eclipse.org/r/58303

Comment 3 Ihor Yatsenko

2015-10-22 10:18:13 EDT

Created attachment 257443 [details]
bug fixed

Comment 4 Jonas Helming

2015-10-22 11:34:27 EDT

There is already a fix in Gerrit ready for review...

Comment 5 Eclipse Genie

2015-10-26 03:04:14 EDT

Gerrit change https://git.eclipse.org/r/58303 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=622d8730af7a5e0648f7f7274bc170e134aad612

Comment 6 Jonas Helming

2015-10-26 03:04:46 EDT

Fixed by adding validation

Comment 7 Lars Vogel

2015-10-26 05:17:31 EDT

See also Bug 480610 for planned tests.