Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 477786 - Gitflow feature finish operation should support keeping the branch
Summary: Gitflow feature finish operation should support keeping the branch
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Gitflow (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-18 05:47 EDT by Max Hohenegger CLA
Modified: 2015-09-22 02:28 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max Hohenegger CLA 2015-09-18 05:47:35 EDT
By default branches are deleted, if the operation succeeded, but the reference implementation supports keeping the branch like this [1].
$ git flow feature finish foobar -k

This change would be nice to have for Gerrit integration [2], so it is possible to peform post-reviews by repeatedly finishing the feature branch with the squash option.

This should work for feature, release and hotfix branches, but we do not have a dialog for release and hotfix yet. I think we can activate the dialog for those branches in a separate change.

[1] https://github.com/nvie/gitflow/wiki/Command-Line-Arguments
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=468885
Comment 1 Eclipse Genie CLA 2015-09-19 12:20:22 EDT
New Gerrit change created: https://git.eclipse.org/r/56299
Comment 2 Eclipse Genie CLA 2015-09-22 02:28:11 EDT
Gerrit change https://git.eclipse.org/r/56299 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=6e4bb5c683663313a0a714593bd90dc9bf6153ea
Comment 3 Matthias Sohn CLA 2015-09-22 02:28:40 EDT
submitted