Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 477711 - Build input script should not create new SWT version if nothing has changed
Summary: Build input script should not create new SWT version if nothing has changed
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.6 M5   Edit
Assignee: Lakshmi P Shanmugam CLA
QA Contact: Arun Thondapu CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-17 09:11 EDT by Markus Keller CLA
Modified: 2016-02-23 13:09 EST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2015-09-17 09:11:19 EDT
For a few weeks now, I see too many build inputs from SWT even if nothing has changed.

Basically every time you see two consecutive commits with the same message v460*:
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/log/

E.g. between I20150916-0800 and I20150916-2000, there was no change, but the SWT bundle qualifier was still increased.
Comment 1 David Williams CLA 2015-09-17 10:05:16 EDT
There was no change ... but, there was a commit. Is that what you mean? 

If so, is that due to some "automatic process"? 

In other words, not sure if this is "my" problem to solve, or "SWT's"? :)
Comment 2 Markus Keller CLA 2015-09-17 10:53:46 EDT
(In reply to David Williams from comment #1)
> In other words, not sure if this is "my" problem to solve, or "SWT's"? :)

It's SWT's. I just CCd you to make you aware of this problem in case you wondered why so many features were updated for I20150916-2000, given there were only few changed bundles. Since everything with UI includes SWT, this ripples up.

> There was no change ... but, there was a commit. Is that what you mean? 

Yes. SWT has some semi-automatic processes that build natives and do the necessary parallel build inputs on the swt.git and swt.binaries.git repos. If there was no real change since the last build input, nothing should be committed.
Comment 3 Arun Thondapu CLA 2015-12-10 03:54:29 EST
We're deliberating a solution for this problem but not finalized it yet, planning to finalize and fix over the next few days...
Comment 4 Lakshmi P Shanmugam CLA 2016-01-05 04:40:30 EST
This is fixed now.
write_qualifier is required only for I-build, not for N-build. Modified the build script and SWT Hudson jobs accordingly.

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=83a8865c3136b636097de60257565cd4a08473a1
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=74300331b684b6a97da726300778f6c513e8bc3f
Comment 5 Markus Keller CLA 2016-02-23 06:47:01 EST
What's the deal with the version number? Since 2015-12-22, v4612 is used as tag and in the SWT native libraries name.

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=0cc28848a42b0c7116a7152ca9afae53c20146ef was pushed on 2016-02-17. Shouldn't we be at 4613 now?
Comment 6 Arun Thondapu CLA 2016-02-23 13:09:32 EST
(In reply to Markus Keller from comment #5)
> What's the deal with the version number? Since 2015-12-22, v4612 is used as
> tag and in the SWT native libraries name.
> 
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=0cc28848a42b0c7116a7152ca9afae53c20146ef was pushed on 2016-02-17.
> Shouldn't we be at 4613 now?

The version update happens only in the next I-build after native changes are introduced. In this case, it just happened that we had changes to native files after a longer gap than usual... the version is now bumped up to 4613 with today's I-build.