Community
Participate
Working Groups
People using the startexplorer plugin have used some of its features that duplicate the Platform features (Show In > System Explorer) because of it's providing a keyboard shortcut where Platform doesn't. See https://github.com/basti1302/startexplorer/issues/64 for reference. The "Show In > System Explorer" should probably provide the same keyboard shortcut (Alt+Ctrl+E).
New Gerrit change created: https://git.eclipse.org/r/56153
Since this is a trivial change with a working Gerrit patch available, why has it been moved to M5? No-one will have time to look at a few lines of plugin.xml before December?
(In reply to Mickael Istria from comment #2) > Since this is a trivial change with a working Gerrit patch available, why > has it been moved to M5? No-one will have time to look at a few lines of > plugin.xml before December? If another committer want to review this, he can put it back to the milestone. I personally will not have the time to review it for M3.
Ok, so I'm moving it back to M3 to make it clear that it's open for review and merge in M3. Then if it appears that no committer could review that patch before M3, we'll slip it to target M4 and then M5 and then... until it gets merged. It's still surprising that with the army of Platform/UI committer, such trivial patches fail at finding reviewers. In many organizations, reviewing an incoming patch is the top-priority task. That makes it efficient since code doesn't remain undelivered, so value is shipped continuously as soon as it's available. But that's probably a discussion I'll send to the mailing-list.
(In reply to Mickael Istria from comment #4) > In many organizations, reviewing an incoming patch is the top-priority task. Have a look how many platform UI developers are reviewing patches...
(In reply to Lars Vogel from comment #5) > Have a look how many platform UI developers are reviewing patches... Yeah, I know. I believe with the more open process that is in place nowadays, all committers should review patches, or be removed their commit rights. It would be more fair.
(In reply to Mickael Istria from comment #6) > (In reply to Lars Vogel from comment #5) > > Have a look how many platform UI developers are reviewing patches... > > Yeah, I know. I believe with the more open process that is in place > nowadays, all committers should review patches, or be removed their commit > rights. It would be more fair. Fair to whom? To people without commit rights? This way you will loose the last willing people with commit rights. I do not review platform UI patches often because I do all the OS work in my free time and my top prio are patches and fixes in egit/jgit area. So why should I lost my commit rights on platform UI then? Will this be fair?
Gerrit change https://git.eclipse.org/r/56153 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=101352ebd1d1c725664e5671be8731b5e17c0b32
Thanks Mickael. Fixed for M3.
Ctrl+Alt+<X> shortcuts should not be assigned by default, since Ctrl+Alt is equivalent to AltGr on many international keyboards on Windows. E.g. on a German keyboard, Ctrl+Alt+E produces the Euro sign €. This is broken in master.
(In reply to Markus Keller from comment #10) > Ctrl+Alt+<X> shortcuts should not be assigned by default, since Ctrl+Alt is > equivalent to AltGr on many international keyboards on Windows. E.g. on a > German keyboard, Ctrl+Alt+E produces the Euro sign €. This is broken in > master. What is the correct action here Markus? Revert the commit?
Either revert the commit, or find a better shortcut. I would actually leave it up to the user. Some users will use this command very often, and they can easily add a shortcut. Other users use other commands very often, and it would be bad for them if they don't find free shortcuts for their favorite command because we assigned a shortcut to this command.
Users don't like to configure their IDE (adding shortcuts, settings preferences...). If you look at the GitHub issue that was referenced in comment 0 as the source reason for this change, it seems like some users even install plugins just to get shortcuts. Leaving choice to the user doesn't please them. However, I have to admit I do not consider this as a critical feature, and if it has to be abandonned or reverted in order to save resources for more interesting features, I'm fine with that.
New Gerrit change created: https://git.eclipse.org/r/58958
Gerrit change https://git.eclipse.org/r/58958 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c661b126db6160ce84945d3382eadb7e519c6d19
Thanks Markus and Mickael. I reverted the commit and we follow Markus advice to leave that shortcut for the user to configure.
How about shift+ctrl+alt+E ?
Created attachment 257548 [details] example picture for keyboard map for Eclipse shortcut
(In reply to Marc-Andre Laperle from comment #17) > How about shift+ctrl+alt+E ? That is used for Embeded Windows Explorer https://github.com/culmat/eExplorer Eclipse TM Terminal is using Ctrl+Alt+T and Ctrl+Alt+Shift+T Is there keyboard map for Eclipse shortcut (some summary as on images just attached)?
Created attachment 257549 [details] Example 2
