Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 476931 - Please enable Gerrit for git://git.eclipse.org/gitroot/platform/eclipse.platform.images.git
Summary: Please enable Gerrit for git://git.eclipse.org/gitroot/platform/eclipse.platf...
Status: CLOSED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Gerrit (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eclipse Webmaster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 476958
  Show dependency tree
 
Reported: 2015-09-09 01:23 EDT by Lars Vogel CLA
Modified: 2015-09-09 08:24 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2015-09-09 01:23:14 EDT
In Bug 422139 Markus Keller created a new repo for our images in platform. Please enable Gerrit on this. 

+1 from platform UI project lead (me) for this. If platform UI does not own this repo it should be moved to us, I don't know where I see the ownership of this repo.
Comment 1 Mikaël Barbero CLA 2015-09-09 05:17:23 EDT
I found 2 repos for platform images:

- eclipse.images (https://git.eclipse.org/r/#/admin/projects/platform/eclipse.images), owned by platform.ui (see on https://git.eclipse.org/r/#/admin/projects/platform/eclipse.images,access that it inherits from the platform.ui permissions project).
- eclipse.platform.images (https://git.eclipse.org/r/#/admin/projects/platform/eclipse.platform.images). Owned by nobody (https://git.eclipse.org/r/#/admin/projects/platform/eclipse.platform.images,access)

So eclipse.images already is gerrit enabled. So is eclipse.platform.images while lacking permissions for platform.ui committers. 

After quickly reading comments on bug 422139, I am a bit confused what is your issue. Please tell me which repo you want to be gerrit enabled
Comment 2 Lars Vogel CLA 2015-09-09 05:37:46 EDT
https://git.eclipse.org/r/#/admin/projects/platform/eclipse.platform.images should be owned by platform.ui and we want Gerrit enabled.

https://git.eclipse.org/r/#/admin/projects/platform/eclipse.images can be deleted in the future but I plan to do this via a separate bug, for now it is still needed for the transition.
Comment 3 Mikaël Barbero CLA 2015-09-09 05:48:22 EDT
Done. 

For the records, the files in /gitroot/platform/eclipse.platform.images.git were missing some ACLs. Markus probably forgot the -R option when he set it on the folder ;)
Comment 4 Markus Keller CLA 2015-09-09 06:03:21 EDT
(In reply to Mikael Barbero from comment #3)
> For the records, the files in /gitroot/platform/eclipse.platform.images.git
> were missing some ACLs. Markus probably forgot the -R option when he set it
> on the folder ;)

Thanks Mikael, that's very helpful. I had to fight with different syntaxes of the setfacl command on different platforms, and the missing man pages on build.eclipse.org didn't make that easier. In the end, I indeed forgot -R.
Comment 5 Markus Keller CLA 2015-09-09 08:09:28 EDT
Mikael, could you also align
https://git.eclipse.org/r/#/admin/projects/platform/eclipse.platform.images with https://git.eclipse.org/r/#/admin/projects/platform/eclipse.platform.ui ?

Description: Eclipse Platform Images
Submit Type: Fast Forward Only
Comment 6 Mikaël Barbero CLA 2015-09-09 08:21:24 EDT
(In reply to Markus Keller from comment #5)
> Mikael, could you also align
> https://git.eclipse.org/r/#/admin/projects/platform/eclipse.platform.images
> with https://git.eclipse.org/r/#/admin/projects/platform/eclipse.platform.ui
> ?
> 
> Description: Eclipse Platform Images
> Submit Type: Fast Forward Only

Done.