Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 475569 - [Composite Diagram] DnD strategy mechanism should be used to create PropertyPart
Summary: [Composite Diagram] DnD strategy mechanism should be used to create PropertyPart
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Diagram (show other bugs)
Version: 1.1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.0   Edit
Assignee: Camille Letavernier CLA
QA Contact: Remi Schnekenburger CLA
URL:
Whiteboard: montages
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-21 04:56 EDT by Remi Schnekenburger CLA
Modified: 2017-05-10 04:16 EDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remi Schnekenburger CLA 2015-08-21 04:56:31 EDT 
The current drag and drop strategy mechanism is not used currently to implement this specific behavior. This specific drop should be handled relying on the dnd strategy.
Comment 1 Remi Schnekenburger CLA 2015-08-21 04:57:16 EDT 
The specific drop is the drop of a classifier to create a property part on the composite structure
Comment 2 Eclipse Genie CLA 2015-09-14 07:44:17 EDT 
New Gerrit change created: https://git.eclipse.org/r/55849
Comment 4 Patrick Tessier CLA 2015-10-14 08:56:06 EDT 
Hi, it is impossible to drop a  class in to compartment of a composite.
 It does not create a propertye typed by the dropped class.

It has be bone on Neon
Comment 5 Eclipse Genie CLA 2015-10-20 10:24:29 EDT 
New Gerrit change created: https://git.eclipse.org/r/58519
Comment 6 Eclipse Genie CLA 2015-10-20 10:24:31 EDT 
New Gerrit change created: https://git.eclipse.org/r/58518
Comment 7 Eclipse Genie CLA 2015-10-20 10:24:33 EDT 
New Gerrit change created: https://git.eclipse.org/r/58520
Comment 9 Camille Letavernier CLA 2016-01-07 07:34:13 EST 
This contribution breaks the tests for SysML 1.1, as this drop strategy is enabled e.g. in SysML Internal Block Diagram. However, this strategy won't work in this diagram:

!ENTRY org.eclipse.papyrus.infra.gmfdiag.dnd 4 0 2016-01-07 13:29:31.943
!MESSAGE Unexpected Error
!STACK 0
org.eclipse.core.runtime.AssertionFailedException: null argument:failed to create a view
	at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:85)
	at org.eclipse.gmf.runtime.diagram.ui.commands.CreateCommand.doExecuteWithResult(CreateCommand.java:96)
	at org.eclipse.gmf.runtime.emf.commands.core.command.AbstractTransactionalCommand.doExecute(AbstractTransactionalCommand.java:247)
	at org.eclipse.emf.workspace.AbstractEMFOperation.execute(AbstractEMFOperation.java:150)
	at org.eclipse.gmf.runtime.diagram.ui.commands.ICommandProxy.execute(ICommandProxy.java:68)
	at org.eclipse.gef.commands.CompoundCommand.execute(CompoundCommand.java:129)
	at org.eclipse.gef.commands.CompoundCommand.execute(CompoundCommand.java:129)
	at org.eclipse.papyrus.infra.gmfdiag.dnd.strategy.TransactionalDropStrategy$1.doExecuteWithResult(TransactionalDropStrategy.java:54)
	[...]

SysML already provides a drop strategy for this case that works in IBD, but it is now conflicting with this new strategy.

This causes at least the following test failures:

org.eclipse.papyrus.sysml.diagram.internalblock.tests.dnd.altdrop.TestTypeDropOnBlock.testDropDataTypeOnBlockCpt
org.eclipse.papyrus.sysml.diagram.internalblock.tests.dnd.altdrop.TestTypeDropOnBlock.testDropBlockOnBlock
org.eclipse.papyrus.sysml.diagram.internalblock.tests.dnd.altdrop.TestTypeDropOnBlock.testDropDataTypeOnBlock
org.eclipse.papyrus.sysml.diagram.internalblock.tests.dnd.altdrop.TestTypeDropOnBlock.testDropFlowSpecOnBlock
org.eclipse.papyrus.sysml.diagram.internalblock.tests.dnd.altdrop.TestTypeDropOnBlock.testDropActorOnBlockCpt
org.eclipse.papyrus.sysml.diagram.internalblock.tests.dnd.altdrop.TestTypeDropOnBlock.testDropActorOnBlock
org.eclipse.papyrus.sysml.diagram.internalblock.tests.dnd.altdrop.TestTypeDropOnBlock.testDropFlowSpecOnBlockCpt
org.eclipse.papyrus.sysml.diagram.internalblock.tests.dnd.altdrop.TestTypeDropOnBlock.testDropBlockOnBlockCpt
Comment 10 Eclipse Genie CLA 2016-02-12 06:15:30 EST 
New Gerrit change created: https://git.eclipse.org/r/66486
Comment 11 Camille Letavernier CLA 2016-02-22 07:51:41 EST 
I'll fix Comment 9
Comment 12 Camille Letavernier CLA 2016-02-22 08:01:54 EST 
https://git.eclipse.org/r/67049
Comment 13 Benoit Maggi CLA 2016-09-23 10:56:26 EDT 
Tests fixed by Camille contribution