Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 475203 - Changes in icons not reflected in application model editor
Summary: Changes in icons not reflected in application model editor
Status: CLOSED DUPLICATE of bug 472658
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.5.2   Edit
Assignee: Olivier Prouvost CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 465271
Blocks:
  Show dependency tree
 
Reported: 2015-08-17 17:44 EDT by Lars Vogel CLA
Modified: 2015-09-04 06:07 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2015-08-17 17:44:50 EDT 
+++ This bug was initially created as a clone of Bug #465271 +++

If I select other icon via the application model editor I need to reopen the editor to see the change.
Comment 1 Lars Vogel CLA 2015-08-17 17:45:13 EDT 
Oliver, is it possible to fix this for 4.5.1?
Comment 2 Eclipse Genie CLA 2015-08-17 17:49:09 EDT 
New Gerrit change created: https://git.eclipse.org/r/53920
Comment 3 Olivier Prouvost CLA 2015-08-17 17:58:42 EDT 
When is the date for 4.5.1 exactly ? 

Probably next week I will have some time to check it...

Did you copy exactly the review from bug 465271 ?
Comment 5 Lars Vogel CLA 2015-08-18 02:56:41 EDT 
(In reply to Eclipse Genie from comment #4)
> Gerrit change https://git.eclipse.org/r/53920 was merged to
> [R4_5_maintenance].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/
> ?id=a2c8702e9dc7ea82f908b10afce58a9f6d00dd9e

This actually belongs to Bug 465271.
Comment 6 Lars Vogel CLA 2015-08-18 02:58:06 EDT 
(In reply to Olivier Prouvost from comment #
> Did you copy exactly the review from bug 465271 ?

I used the Neon version of the e4 tools for testing using the following update site: http://download.eclipse.org/eclipse/updates/N-builds
Comment 7 Lars Vogel CLA 2015-09-03 14:48:43 EDT 
(In reply to Lars Vogel from comment #6)
> (In reply to Olivier Prouvost from comment #
> > Did you copy exactly the review from bug 465271 ?
> 
> I used the Neon version of the e4 tools for testing using the following
> update site: http://download.eclipse.org/eclipse/updates/N-builds

Olivier, any update here from your side?
Comment 8 Olivier Prouvost CLA 2015-09-04 05:31:45 EDT 
Excuse me Lars but I dont understand what you want me to do...

This patch has been merged in 4.5.1 but not yet in neon.. ?
Comment 9 Lars Vogel CLA 2015-09-04 05:52:05 EDT 
(In reply to Olivier Prouvost from comment #8)
> Excuse me Lars but I dont understand what you want me to do...
> 
> This patch has been merged in 4.5.1 but not yet in neon.. ?

The patch is in Neon AFAICS but it looks like we still have the issue that the icons are not dynamically updated. If I change an icon I need to close the application editor and reopen it. Both in Neon and Mars.
Comment 10 Olivier Prouvost CLA 2015-09-04 06:07:39 EDT 
Ok ! 

Actually there is already another bug for that.. I put this one as duplicate.

*** This bug has been marked as a duplicate of bug 472658 ***