Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 47176 - [Navigator] Excessive flicker when moving or renaming resource
Summary: [Navigator] Excessive flicker when moving or renaming resource
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P4 normal (vote)
Target Milestone: ---   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-20 16:26 EST by Nick Edgar CLA
Modified: 2007-06-18 15:34 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2003-11-20 16:26:13 EST
build I20031119

- In a self-hosting workspace, create two projects: A and Z, so that A is at 
the top of a long list of projects, and Z is at the bottom.
- Create a file under A, e.g. Test.txt.
- In the Navigator view, select it and choose File > Move...
- Specify Z as the destination
- the view flickers noticeably
- Move it back to A
- same flicker

May be related to recent changes to WorkbenchContentProvider
Comment 1 Nick Edgar CLA 2003-11-20 16:30:34 EST
Try also renaming a file.  After hitting enter for the new name, the old name 
flashes before showing the new name.  

This should not be the case because WorkbenchContentProvider processes the 
delta in a syncExec, so no UI events should get processed until the delta is 
communicated to the viewer in its entirety.  Perhaps we're getting multiple 
deltas now.

This is particularly noticeable when the resource being renamed is the last 
node in a big tree.  When the old element is deleted, the list scrolls down, 
then scrolls back up to reveal the new element.
Comment 2 Kim Horne CLA 2004-03-16 14:57:56 EST
I dont see the flicker on move... are you still seeing it?

The rename behaviour you're seeing is a consequence of the fact that we're doing
renaming inline using a TreeEditor.  When you hit enter the cell editor
disappears and the original label is shown.  Then the delta is fired and the
label is updated.  I've added a fix that will prevent this.  The delta is fired
before the wigdet is closed.
Comment 3 Nick Edgar CLA 2004-03-16 15:03:46 EST
Move seems OK now.

For rename, it wasn't just the cell editor hiding before the label was updated.
When the item being renamed is the last one in the tree, the tree scrolls down 
then back up, as if we're getting separate deltas for deletion then addition 
rather than just one (which we should be able to decipher as a move).
Comment 4 Nick Edgar CLA 2004-03-16 15:05:13 EST
To clarify, the delta has flags indicating whether a removal or additon is due 
to a move, and where it has moved from/to.  See IResourceDelta.MOVED_FROM and 
MOVED_TO.

Comment 5 Kim Horne CLA 2007-06-18 15:34:49 EDT
I can no longer reproduce.