Comment 1 Matthias Sohn 2015-06-22 15:36:06 EDT

+1

Comment 2 Max Hohenegger 2015-06-26 07:20:00 EDT

@Matthias, I have a running UI test for the FeatureRebaseHandler, but I need a lot of code from o.e.egit.ui.test. Since it is a fragment, I cannot simply import it. Would it make sense to refactor this and move the code into a new bundle: o.e.egit.common.ui.test?
Otherwise, I have to either duplicate several hundred lines of code, or re-invent most of it.

Important classes are:
- LocalRepositoryTestCase
- TestUtil
- JobJoiner (I believe this could be removed with SWTBot 2.3.0)

Comment 3 Matthias Sohn 2015-06-26 08:38:50 EDT

I wouldn't mind if you simply add the gitflow ui tests to the existing org.eclipse.egit.ui.test bundle if this reduces the overhead to implement them

I think we should try to update to swtbot 2.3.0 (in another change)

Comment 4 Max Hohenegger 2015-07-01 03:10:10 EDT

https://git.eclipse.org/r/#/c/51157/

Comment 5 Max Hohenegger 2015-07-01 03:12:33 EDT

The above patch-set should be merged before the feature rebase fix [1] because it tests the old behaviour.
I then have to amend that patch-set to test the new behaviour.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=470434

Comment 6 Andrey Loskutov 2015-07-04 17:37:46 EDT

Thanks to this tests I found two issues in egit and gitflow code, see 
https://git.eclipse.org/r/51379 & https://git.eclipse.org/r/51380.

Comment 7 Max Hohenegger 2015-07-05 04:19:00 EDT

Great! Thanks for fixing this.

Comment 8 Andrey Loskutov 2015-07-05 09:46:29 EDT

Merged with http://git.eclipse.org/c/egit/egit.git/commit/?id=d46e03b5cd2828d4a84153e0537d761f7f7fbc40