Description Jonathan CLAUDE 2015-06-09 05:02:34 EDT

Hi all,

Switching our product from eclipse 3.6 to eclipse 4.4, I find a regression on our popup menus. We get some actions we should not have on some tree items.

We have our own implementation of org.eclipse.core.commands.AbstractHandler which override method isEnabled().

What we do when a tree item is selected is something like that :

commandService = (ICommandService) getWorkbench().getAdapter(ICommandService.class)
Command command = commandService.getCommand(cmdId);
IHandler handler = command.getHandler();

if (handler instanceOf MyHandler) {
   ((MyHandler) handler).setEnabled(false);  //to disable the command
}

It used to work in eclipse 3.x but not anymore with eclipse 4.4.2 because instead of MyHandler, I have an instance of WorkbenchHandlerServiceHandler.

I have found a workaround right now but I would like something cleaner if exists to avoid going into internal package of eclipse.

What I do to get my own instance of Handler : 

IEclipseContext eclipseContext = (IEclipseContext) activeWorkbench.getService(IEclipseContext.class); 
Object obj = HandlerServiceImpl.lookUpHandler(eclipseContext, cmdId);
if (obj instanceof E4HandlerProxy) { 
   E4HandlerProxy e4HandlerProxy = (E4HandlerProxy) obj;
   IHandler activeHandler = e4HandlerProxy.getHandler(); 
      if (activeHandler instanceof MyHandler) {
         final MyHandler dHandler = (MyHandler) activeHandler;
         ((MyHandler) dHandler).setEnabled(enabled);
      }
}