Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 469599 - [server] Summary should show real stack trace entry
Summary: [server] Summary should show real stack trace entry
Status: CLOSED FIXED
Alias: None
Product: EPP
Classification: Technology
Component: Automated Error Reporting Client (AERI) (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.5.1RC1   Edit
Assignee: EPP Error Reports CLA
QA Contact:
URL:
Whiteboard: votes
Keywords:
Depends on:
Blocks: 474514
  Show dependency tree
 
Reported: 2015-06-08 04:28 EDT by Dani Megert CLA
Modified: 2015-08-10 05:19 EDT (History)
1 user (show)

See Also:


Attachments
Screenshot (346.70 KB, image/png)
2015-08-10 04:37 EDT, Marcel Bruch CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2015-06-08 04:28:06 EDT
The summary of logged bugs should show the real stack trace entry.

Example bug 469588:

In the summary it shows as:
... in FastPartitioner.documentChanged2 (307)
		
But in the real stack trace it is:
.. in FastPartitioner.documentChanged2(FastPartitioner.java:307)

Eclipse has a nice 'Open from Clipboard' action which tries to directly open the code location present in the clipboard. This doesn't work with the info provided in the summary and hence I have to scroll down in comment 0 to select and copy it from there.


I think the usability gained to quickly open the code location outweighs a longer summary.
Comment 1 Marcel Bruch CLA 2015-06-10 02:02:14 EDT
to clarify: You mean changing " (307)" to "(FastPartitioner.java:307)" only in the summary and only in a bugzilla bug report - not in the general overview pages in the web ui)?
Comment 2 Dani Megert CLA 2015-06-10 02:56:58 EDT
(In reply to Marcel Bruch from comment #1)
> to clarify: You mean changing " (307)" to "(FastPartitioner.java:307)" only
> in the summary and only in a bugzilla bug report - not in the general
> overview pages in the web ui)?

Yep.
Comment 3 Marcel Bruch CLA 2015-08-08 18:07:38 EDT
on which projects? JDT or platform or both?
Comment 4 Dani Megert CLA 2015-08-10 03:42:10 EDT
(In reply to Marcel Bruch from comment #3)
> on which projects? JDT or platform or both?

Platform, JDT and PDE.
Comment 5 Marcel Bruch CLA 2015-08-10 04:37:16 EDT
Created attachment 255748 [details]
Screenshot

(In reply to Dani Megert from comment #4)
> Platform, JDT and PDE.

Done.

Note: This change only affects the manual creation of a bug report via the reporter's web ui. See the attached screenshot for more context.

In particular note that when the preselected product is one of the above, then this summary is created. This should work for most scenarios but sometimes it won't.



It's yet not clear to me whether we should make this a default for all bug creation templates or not. Does the Open from Clipboard command only check for filenames in braces (File.java:line) or is there more logic? What's the class name of that command? A brief search on OpenFrom* or OpenClip* did not show any results.
Comment 6 Dani Megert CLA 2015-08-10 04:57:57 EDT
(In reply to Marcel Bruch from comment #5)
> Does the Open from Clipboard command only check
> for filenames in braces (File.java:line) or is there more logic?

It uses various patterns, see class below.

> What's the
> class name of that command? A brief search on OpenFrom* or OpenClip* did not
> show any results.

org.eclipse.jdt.internal.debug.ui.actions.OpenFromClipboardAction
Comment 7 Marcel Bruch CLA 2015-08-10 05:14:09 EDT
(In reply to Dani Megert from comment #6)

After reading through all patterns (FastPartitioner.java:307) seems to be the best one available. 

However, it might be worth to add support for new patterns to keep the summary short.

FastPartitioner.documentChanged2 (307) 
FastPartitioner.documentChanged2 (line: 307)
FastPartitioner#documentChanged2:307
FastPartitioner.documentChanged2 : 307 or
FastPartitioner#documentChanged2 line: 307


Thats something to consider if other projects would like to have the same support but have trouble with long summaries. Thx.
Comment 8 Dani Megert CLA 2015-08-10 05:19:16 EDT
(In reply to Marcel Bruch from comment #7)
> FastPartitioner.documentChanged2 (307) 
> FastPartitioner.documentChanged2 (line: 307)
> FastPartitioner#documentChanged2:307
> FastPartitioner.documentChanged2 : 307 or
> FastPartitioner#documentChanged2 line: 307
> 
> 
> Thats something to consider if other projects would like to have the same
> support but have trouble with long summaries. Thx.

We can consider on a per request basis.