Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 469113 - Enable GTK3 for GTK < 3.10.9 as well on ppc64le platform
Summary: Enable GTK3 for GTK < 3.10.9 as well on ppc64le platform
Status: VERIFIED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Launcher (show other bugs)
Version: 4.5.0 Mars   Edit
Hardware: Power PC Linux
: P3 normal (vote)
Target Milestone: Mars RC4   Edit
Assignee: Sravan Kumar Lakkimsetti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-02 07:38 EDT by Lakshmi P Shanmugam CLA
Modified: 2015-07-07 07:30 EDT (History)
9 users (show)

See Also:
daniel_megert: pmc_approved+
lshanmug: review+
arunkumar.thondapu: review+
niraj.modi: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lakshmi P Shanmugam CLA 2015-06-02 07:38:20 EDT 
+++ This bug was initially created as a clone of Bug #467991 +++

This bug is to remove the specific gtk3 version checks in the launcher for ppc64le platform.

The fix is to revert the changes made in Bug 441421 and Bug 467991.
Comment 1 Lakshmi P Shanmugam CLA 2015-06-02 07:39:58 EDT 
New Gerrit change created: https://git.eclipse.org/r/49185
Comment 2 Lakshmi P Shanmugam CLA 2015-06-02 07:41:57 EDT 
+1, its better to remove the specific version checks from launcher if it works with gtk version 3.8.
Comment 3 Arun Thondapu CLA 2015-06-02 07:49:48 EDT 
+1, I tested the existing launcher and SWT binaries on RHEL 7.1 (GTK+ 3.8.8) and its working fine. Dropping the explicit version check will enable GTK3 to be the default on RHEL 7.1 (and other distros with GTK < 3.10.9) on ppc64le for Mars.
Comment 4 Niraj Modi CLA 2015-06-02 07:58:14 EDT 
+1 for reverting the version checks in launcher code, which were recently introduced.
Comment 6 Arun Thondapu CLA 2015-06-02 11:17:35 EDT 
Rebuilt launcher binaries for ppc64le are committed via https://git.eclipse.org/c/equinox/rt.equinox.binaries.git/commit/?id=79dc26b5a30fe17ba63f9677e84d3d965b84f189

Will test tomorrow with next I-build.
Comment 7 Arun Thondapu CLA 2015-06-03 07:42:34 EDT 
(In reply to Arun Thondapu from comment #6)
> Rebuilt launcher binaries for ppc64le are committed via
> https://git.eclipse.org/c/equinox/rt.equinox.binaries.git/commit/
> ?id=79dc26b5a30fe17ba63f9677e84d3d965b84f189
> 
> Will test tomorrow with next I-build.

Verified with I20150602-2000 on RHEL 7.1, Eclipse launches with GTK3 by default now.