468937 – [Graphics] Replace org.eclipse.pde.runtime icons in PDE with png files

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 468937 - [Graphics] Replace org.eclipse.pde.runtime icons in PDE with png files

Summary: [Graphics] Replace org.eclipse.pde.runtime icons in PDE with png files

Status:	VERIFIED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.5
Hardware:	PC Linux

Importance:	P3 normal with 1 vote (vote)
Target Milestone:	4.7 M2
Assignee:	Matthias Becker
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	468945
	Show dependency tree

Reported:	2015-06-01 04:59 EDT by Lars Vogel
Modified:	2016-09-15 03:03 EDT (History)
CC List:	5 users (show)

See Also:	Gerrit Change Gerrit Change Git Commit Git Commit

Attachments
Comparison of old ( left ) and new ( right ) (70.88 KB, image/png) 2016-09-06 09:45 EDT, Matthias Becker	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2015-06-01 04:59:52 EDT

Comment 1 Lars Vogel

2015-06-01 05:01:05 EDT

Tony, could you provide svg/png icons for the org.eclipse.pde.runtime plug-in in git://git.eclipse.org/gitroot/pde/eclipse.pde.ui.git? 

AFAICS these are mainly copies of the existing icons.

Comment 2 Dani Megert

2016-05-20 10:43:40 EDT

Too late for this.

Comment 3 Matthias Becker

2016-09-06 09:45:08 EDT

Created attachment 263992 [details]
Comparison of old ( left ) and new ( right )

The old icon already was available as PNG if you don't see an icon in the "old" column.

Comment 4 Eclipse Genie

2016-09-06 16:50:13 EDT

New Gerrit change created: https://git.eclipse.org/r/80477

Comment 5 Eclipse Genie

2016-09-06 16:50:15 EDT

New Gerrit change created: https://git.eclipse.org/r/80478

Comment 6 Matthias Becker

2016-09-07 06:51:29 EDT

Do I need to add somebody of the PDE-Team to gerrit change as reviewer? If yes: Who would that be?

Comment 7 Lars Vogel

2016-09-07 12:58:41 EDT

(In reply to Matthias Becker from comment #6)
> Do I need to add somebody of the PDE-Team to gerrit change as reviewer? If
> yes: Who would that be?

No worries, I'm also a PDE committer and will review latest this Friday.

Comment 8 Eclipse Genie

2016-09-08 02:01:07 EDT

Gerrit change https://git.eclipse.org/r/80478 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=60865c4e342c3fd74f6ae0c13097dadb072b847b

Comment 9 Eclipse Genie

2016-09-08 02:02:00 EDT

Gerrit change https://git.eclipse.org/r/80477 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=fe11360edec663af2c07c62defa68eaf1d8b007e

Comment 10 Lars Vogel

2016-09-08 02:02:11 EDT

Thanks Matthias

Comment 11 Vikas Chandra

2016-09-15 02:56:36 EDT

Looks like 

org.eclipse.pde.runtime\icons\eview16\horizontal_view.gif
org.eclipse.pde.runtime\icons\eview16\registry.gif
org.eclipse.pde.runtime\icons\eview16\vertical_view.gif

needs to be deleted.

Lars, can you please verify that this is the case and  take this up sometime next week if this is the case.

Comment 12 Matthias Becker

2016-09-15 02:58:56 EDT

Eclipse references view-icons somewhere in the workbench layout data. If we delete these files existing workspaces will get the red "icon not found" replacement icon at startup (until you activate the view). So as a workaround we keep these old GIFs.

Comment 13 Vikas Chandra

2016-09-15 03:03:26 EDT

Thanks Matthias for the input.

Now marked as verified.