Community
Participate
Working Groups
Created attachment 253690 [details] An EEF wizard with the intermediate empty shell visible Steps to reproduce: 1. Launch a Mars RC1 modeling package (or equivalent), with EEF 1.5 and Ecore Tools 3.0 (not tested with other versions of EEF and Ecore Tools). 2. Create a basic Ecore diagram using Ecore Tools, with at least one EClass visible on the diagram. 3. Double-click on the diagram to open the edition wizard. In addition to the wizard itself, an empty SWT shell (competely blank/grey) is visible between the workbench and the wizard. It can not be closed until the wizard is closed, and *must* be manually closed after the wizard to get back to the workbench. It seems specific to Mars, the same scenario with EEF 1.5, Ecore Tools 3.0 but on Luna does not show the invalid shell. From what I saw in the code (patch incoming), I suspect that EEF had the bug basically forever, but it was made visible by some change in the Mars version of SWT (at least for Linux), which makes intermediate shells visible even if empty. Note that I am under Linux (Ubuntu 15.04 64 bits, Java 1.8). The broken behavior happens with or without SWT_GTK3=0. I have not tested on other platforms.
Cedric, I'm adding you in CC as this impacts Ecore Tools and the Modeling package for Mars.
Created attachment 253691 [details] Tentative patch Here's a patch against EEF master which seems to fix the issue. Note that I am not familiar with the EEF codebase and I have not tested it extensively, so take it as a tentative fix.
https://git.eclipse.org/r/#/c/45966/ for bug 462637 looks like a good candidate for the behavior change. From the commit message: "Make sure that the parent shell is always opened before a child shell is opened." This was merged recently in SWT (about a month ago).
Patch applied
