Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 46771 - PDE shouldn't reformat my plugin.xml file
Summary: PDE shouldn't reformat my plugin.xml file
Status: RESOLVED DUPLICATE of bug 37661
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-17 09:23 EST by Dirk Baeumer CLA
Modified: 2004-02-25 22:26 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Baeumer CLA 2003-11-17 09:23:22 EST
N20031114

This drives me nuts anytime it happens. Whenever I use PDE's plug-in.xml 
editor and use one of the nice form pages to change something my whole 
plugin.xml file gets reformatted. Please only reformt the parts that needs to 
be updated. 

The current formatting behaviour at least has the effect on me that I avoid 
using the pde editor.
Comment 1 Dejan Glozic CLA 2003-11-17 09:30:04 EST
This is a long-standing issue. We feel your pain and plan to address it in 
3.0, but it is not easy to carefully add or remove sections of the source 
around your code. The current implementation simply rewrites the entire file 
based on the data in the structured model. Of course, we don't loose 
information, but the fact remains that we dump your file and write our own.
Comment 2 Dirk Baeumer CLA 2003-11-17 09:57:07 EST
You might want to have a look at the text edits provided by org.eclipse.text. 
We use them for applying minimal changes to compilation units.
Comment 3 Dejan Glozic CLA 2003-11-17 10:18:06 EST
Dirk, the edit stuff looks very promising. Is there a way for us to learn more 
about it?

As a side note, we were completely unaware of this feature, implying that we 
must advertise to each other more about what we are doing if we are to avoid 
duplication.
Comment 4 Dirk Baeumer CLA 2003-11-17 12:14:43 EST
Dejan, we will advertise it for M5. This is code we implemented for 
refactoring and pushed down to text for M4. But we wanted to have one 
milestone to stabilize it before to advertise it to others.

Thers isn't any documentation yet other than Javadoc and code ;-). You can 
look at the various refactorings and the AST rewriting that make use of it. 
Futhermore there are test cases (currently in JDT/UI). The test class is 
TextEditTests.
Comment 5 Dejan Glozic CLA 2003-11-17 12:33:37 EST
OK, that makes sense. I was concerned that this great capability we needed for 
a long time to make 'gentler' multi-page editors was available for a long 
time, and we simply didn't know about it.
Comment 6 Wassim Melhem CLA 2004-02-25 22:26:42 EST

*** This bug has been marked as a duplicate of 37661 ***