Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 466840 - Add missing gif files for for views and editors in pde.de
Summary: Add missing gif files for for views and editors in pde.de
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.5 RC1   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 465456
Blocks:
  Show dependency tree
 
Reported: 2015-05-08 09:20 EDT by Markus Keller CLA
Modified: 2016-06-03 09:26 EDT (History)
3 users (show)

See Also:
Vikas.Chandra: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2015-05-08 09:20:57 EDT
I20150507-2000

To work around bug 465456, bundles need to keep the *.gif icons of values contributed in extension points:
- org.eclipse.ui.editors > editor > icon (typically in /icons/full/obj16/)
- org.eclipse.ui.views > view > icon (complete /icons/full/eview16/ folder)


!ENTRY org.eclipse.jface 4 0 2015-05-08 12:22:22.974
!MESSAGE /icons/obj16/ftr_xml_obj.gif
!STACK 0
java.io.FileNotFoundException: /icons/obj16/ftr_xml_obj.gif
        at org.eclipse.osgi.storage.url.bundleentry.Handler.findBundleEntry(Handler.java:37)
        at org.eclipse.osgi.storage.url.BundleResourceHandler.openConnection(BundleResourceHandler.java:169)
        at java.net.URL.openConnection(URL.java:972)
        at org.eclipse.core.internal.boot.PlatformURLConnection.connect(PlatformURLConnection.java:112)
        at org.eclipse.core.internal.boot.PlatformURLConnection.getURLAsLocal(PlatformURLConnection.java:244)
        at org.eclipse.core.internal.runtime.PlatformURLConverter.toFileURL(PlatformURLConverter.java:37)
        at org.eclipse.core.runtime.FileLocator.toFileURL(FileLocator.java:207)
        at org.eclipse.jface.resource.URLImageDescriptor.getFilePath(URLImageDescriptor.java:219)
        at org.eclipse.jface.resource.URLImageDescriptor.createImage(URLImageDescriptor.java:283)
        at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:224)
        at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:202)
        at org.eclipse.e4.ui.workbench.renderers.swt.SWTPartRenderer.getImageFromURI(SWTPartRenderer.java:225)
        at org.eclipse.e4.ui.workbench.renderers.swt.SWTPartRenderer.getImage(SWTPartRenderer.java:236)
        at org.eclipse.e4.ui.workbench.renderers.swt.StackRenderer.createTab(StackRenderer.java:877)
        at org.eclipse.e4.ui.workbench.renderers.swt.LazyStackRenderer.processContents(LazyStackRenderer.java:139)
        at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:654)
        at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:746)
        at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.access$0(PartRenderingEngine.java:717)
        at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$2.run(PartRenderingEngine.java:711)
...
Comment 1 Eclipse Genie CLA 2015-05-08 15:40:35 EDT
New Gerrit change created: https://git.eclipse.org/r/47552
Comment 3 Vikas Chandra CLA 2015-05-09 04:48:33 EDT
Thanks Lars !
Comment 4 Vikas Chandra CLA 2015-05-09 04:49:48 EDT
Markus, can you please verify this on Monday on a high priority.
Comment 5 Markus Keller CLA 2015-05-11 06:07:47 EDT
I reported one exception and the general problem. Fixing that single image is of course not enough to fix this bug. You have to make a pass over all extension point contributions and restore all editor and view images you find there.
Comment 6 Lars Vogel CLA 2015-05-11 06:25:32 EDT
(In reply to Markus Keller from comment #5)
> I reported one exception and the general problem. Fixing that single image
> is of course not enough to fix this bug. You have to make a pass over all
> extension point contributions and restore all editor and view images you
> find there.

This was done. I just did it again, assuming you found something missing but I could not find another missing reference.
Comment 7 Vikas Chandra CLA 2015-05-11 06:29:24 EDT
Lars,

I had found https://bugs.eclipse.org/bugs/show_bug.cgi?id=466921

Is this fixed now? 

Also an extensive check of all icons on latest eclipse is the way to go.
Comment 8 Lars Vogel CLA 2015-05-11 06:37:33 EDT
Sorry, my Eclipse Git repo was in a weird mode, it showed no changes but I hard all the gifs included., resetting on the command line shows several missing icons.

Working on this, now.
Comment 9 Lars Vogel CLA 2015-05-11 06:40:50 EDT
These gifs are missing:

schema_obj.gif
build_exec.gif
site_xml_obj.gif
build_exec.gif
discovery.gif
category_obj.gif
Comment 10 Eclipse Genie CLA 2015-05-11 06:47:25 EDT
New Gerrit change created: https://git.eclipse.org/r/47619
Comment 12 Lars Vogel CLA 2015-05-11 06:49:24 EDT
Fixed, sorry for this and thanks to Markus and Vikas for identifying that.
Comment 13 Lars Vogel CLA 2015-05-11 06:49:31 EDT
.
Comment 14 Lars Vogel CLA 2015-05-11 07:48:21 EDT
*** Bug 466921 has been marked as a duplicate of this bug. ***
Comment 15 Vikas Chandra CLA 2015-05-14 07:59:29 EDT
Lars,

Can you please verify this one.
Comment 16 Lars Vogel CLA 2015-05-15 03:54:04 EDT
Verified by playing around with 4.5.0.I20150514-2000 and by not having this bug reopened by Markus. :-)