Comment 1 Lars Vogel 2015-05-04 02:48:43 EDT

Tony, are the icons in org.eclipse.ui.navigator and org.eclipse.ui.navigator.resources uptodate?

Comment 2 Tony McCrary 2015-05-04 20:05:30 EDT

A few need to be updated, I will get them ready this week (probably tomorrow).

Comment 3 Eclipse Genie 2015-05-05 19:25:02 EDT

New Gerrit change created: https://git.eclipse.org/r/47234

Comment 4 Tony McCrary 2015-05-05 19:25:47 EDT

Created attachment 253196 [details]
May 5 2015 Gallery - o.e.u.navigator

Comment 5 Tony McCrary 2015-05-05 19:25:59 EDT

Created attachment 253197 [details]
May 5 2015 Gallery - o.e.u.navigator.resources

Comment 6 Lars Vogel 2015-05-06 12:27:46 EDT

Noopur, do you see the need for improvements for the icons?

Comment 7 Noopur Gupta 2015-05-07 03:59:23 EDT

(In reply to Tony McCrary from comment #4)
> Created attachment 253196 [details]
> May 5 2015 Gallery - o.e.u.navigator
The edges of the last 2 icons "synced" look blurred in dark theme compared to gifs.

(In reply to Tony McCrary from comment #5)
> Created attachment 253197 [details]
> May 5 2015 Gallery - o.e.u.navigator.resources
- Same comment as above for the 2 "synced" icons.
- The tip of "warning_co" icon can be improved (see it in dark theme).
- "nested_projects" doesn't show the corresponding gif in gallery.

Comment 8 Eclipse Genie 2016-04-25 12:41:31 EDT

New Gerrit change created: https://git.eclipse.org/r/71351

Comment 9 Mickael Istria 2016-05-03 06:30:49 EDT

(In reply to Noopur Gupta from comment #7)
> - "nested_projects" doesn't show the corresponding gif in gallery.

The nested_projects icon was directly contributed as .png from its inception.

@Noopur: do you think your other comments are blocker? IMO, icons are mostly better, and we'd rather adopt them and open individual issues for those that need it rather than making them blocker of this overall improvement. WDYT?

Comment 10 Noopur Gupta 2016-05-03 08:08:08 EDT

(In reply to Mickael Istria from comment #9)
> @Noopur: do you think your other comments are blocker? IMO, icons are mostly
> better, and we'd rather adopt them and open individual issues for those that
> need it rather than making them blocker of this overall improvement. WDYT?

The other two issues are not a blocker for this bug. The new icons look good in the default theme. The "synced" icons can be improved for the dark theme.

Comment 11 Dani Megert 2016-05-18 13:19:59 EDT

Moving out of Neon. If you still want to fix something during RC3 then please retarget and make sure you follow the rules: https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_6.php#FixPassAfterRC2

Comment 12 Eclipse Genie 2016-05-25 13:55:13 EDT

Gerrit change https://git.eclipse.org/r/71351 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=915fc45ec26531716727bb1b49469bbce3d6a152

Comment 13 Matthias Becker 2016-09-08 07:37:02 EDT

fixed with https://git.eclipse.org/r/#/c/80659/

Comment 14 Eclipse Genie 2016-09-08 08:02:09 EDT

New Gerrit change created: https://git.eclipse.org/r/80684

Comment 15 Matthias Becker 2016-09-08 08:04:39 EDT

now as separate change in https://git.eclipse.org/r/80684

Comment 16 Lars Vogel 2016-09-08 08:12:42 EDT

Can you upload a gallery comparison?

Comment 17 Matthias Becker 2016-09-08 08:13:45 EDT

(In reply to Lars Vogel from comment #16)
> Can you upload a gallery comparison?

I did not draw any new icons. I just used icons Tony already had created.

Comment 18 Eclipse Genie 2016-09-08 08:17:01 EDT

Gerrit change https://git.eclipse.org/r/80684 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9e322264e00409b4b1b8e353e10f2a7bca509f67

Comment 19 Lars Vogel 2016-09-08 08:18:23 EDT

(In reply to Matthias Becker from comment #17)
> (In reply to Lars Vogel from comment #16)
> > Can you upload a gallery comparison?
> 
> I did not draw any new icons. I just used icons Tony already had created.

Thanks for the clarification and the contribution.