Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 465871 - missing legal files (about.html) in e4 tools source
Summary: missing legal files (about.html) in e4 tools source
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-30 00:53 EDT by David Williams CLA
Modified: 2015-04-30 20:16 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2015-04-30 00:53:51 EDT 
From a recent "sim release report", the following show "missing legal files": 

Missing (?:about|about_org.eclipse.e4.tools).html in file: org.eclipse.e4.tools.source_4.5.0.v20150407-0959.jar
Missing (?:about|about_org.eclipse.e4.tools.compat).html in file: org.eclipse.e4.tools.compat.source_4.5.0.v20150407-0959.jar
Missing (?:about|about_org.eclipse.e4.tools.emf.editor3x).html in file: org.eclipse.e4.tools.emf.editor3x.source_4.5.0.v20150407-0959.jar
Missing (?:about|about_org.eclipse.e4.tools.emf.ui).html in file: org.eclipse.e4.tools.emf.ui.source_4.5.0.v20150407-0959.jar
Missing (?:about|about_org.eclipse.e4.tools.jdt.templates).html in file: org.eclipse.e4.tools.jdt.templates.source_4.5.0.v20150407-0959.jar
Missing (?:about|about_org.eclipse.e4.tools.services).html in file: org.eclipse.e4.tools.services.source_4.5.0.v20150407-0959.jar
Comment 1 David Williams CLA 2015-04-30 00:55:38 EDT 
I think this might be as simple as adding 

src.includes = about.html

to your build.properties files (for each plugin).
Comment 2 David Williams CLA 2015-04-30 00:58:45 EDT 
Also, I'm not sure worth re-spinning M7 just for this ... but, I'd definitively go ahead and commit fix, in case there are other reasons we should re-spin. 

IMHO

CCing Dani in case he has another opinion about re-spinning, after Wayne's note to "cross-project" to "fix these issues!".
Comment 3 David Williams CLA 2015-04-30 02:29:08 EDT 
Lars, another report (bug 465876) by coincidence, shows to issues with "externalization". 


org.eclipse.e4.ui.swt.gtk   1.0.0.v20150429-1559  
fragmentName

org.eclipse.e4.tools.jdt.templates   4.5.0.v20150422-1518  
pluginName

I think what that's saying is that the key used in the manifest, is different than the key used in the plugin.properties (or similar) file, so it is just publishing the key to the repository, instead of the actual name.
Comment 4 Eclipse Genie CLA 2015-04-30 03:12:51 EDT 
New Gerrit change created: https://git.eclipse.org/r/46836
Comment 6 Eclipse Genie CLA 2015-04-30 03:30:46 EDT 
New Gerrit change created: https://git.eclipse.org/r/46839
Comment 8 Lars Vogel CLA 2015-04-30 03:33:23 EDT 
(In reply to David Williams from comment #3)
> Lars, another report (bug 465876) by coincidence, shows to issues with
> "externalization". 
> 
> 
> org.eclipse.e4.ui.swt.gtk   1.0.0.v20150429-1559  
> fragmentName

Opened Bug 465884 for that. This is a new fragment.

> org.eclipse.e4.tools.jdt.templates   4.5.0.v20150422-1518  
> pluginName

Fixed, I hope, with commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=755b55a478d13608fe9f1fcb282c6e4b4da92df4
Comment 9 David Williams CLA 2015-04-30 20:16:17 EDT 
I confirmed with local run, that these "about file" issues no longer show up.