Community
Participate
Working Groups
The new rule to mark missing NLS comments for string literals is cool, but it marks way too many literals that will not ever be shown to a person (i.e. needing to be translated). Consider the following snippet: var c = 'me'; if(c === ',') { var o = { "one": 1 } function f(){} f("d"); } we should be ignoring literals used in 1. comparisons 2. object keys 3. typeof / unary expressions as we find more we can update this list.
4. "use strict"; :)
Also the pref is in the wrong spot on the pref page and spelled wrong.
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5a917ba46af47cb7a02c6826cf5d579c2f2a46f7 Added exceptions for binary/unary expressions and object keys (and 'use strict'). I changed the wording of the preference to match what is in Eclipse and put it alphabetically. Mike suggested renaming the rule to match this wiki page: https://wiki.eclipse.org/Orion/ESLint So I will do that as part of this bug.
(In reply to Curtis Windatt from comment #3) > Mike suggested renaming the rule to match this wiki page: > https://wiki.eclipse.org/Orion/ESLint > > So I will do that as part of this bug. I have the changes ready in my workspace, but had two issues, 1) eslint crashes because it is still looking for the previous rule setting and 2) eventually my editor wouldn't load at all.
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e09c8026f8511a9f466d926cddcd7642179aaa74 This commit contains the entirety of this fix (fix in comment #3 + name change comment #4 + Bug 380818 + Ignore require('foo') call expressions. This was necessary due to Git History shenanigans: Bug 464709
