Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 463913 - [Tools] e4 core tool poms should follow conventions of rest of Eclipse
Summary: [Tools] e4 core tool poms should follow conventions of rest of Eclipse
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 459799
  Show dependency tree
 
Reported: 2015-04-03 14:35 EDT by David Williams CLA
Modified: 2015-04-28 15:01 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2015-04-03 14:35:56 EDT 
I mentioned most of these in bug 463856. 

The only "bit one" is the version of the "repository pom". 

  <groupId>org.eclipse</groupId>
  <artifactId>eclipse.platform.ui.tools</artifactId>
  <version>0.17.0-SNAPSHOT</version>
  <packaging>pom</packaging>

That should be either 1.0.0-SNAPSHOT

or 4.5.0-SNAPSHOT

you may want to study others, to see if they all say "4.5" (in which case, you'd want to do that too .. meaning "part of the 4.5 release".
Comment 1 David Williams CLA 2015-04-03 14:39:29 EDT 
Another, ... not sure how important to any one is that other eclipse projects, have their "root pom" group id, be the name of the repository, so that'd be 

  <groupId>eclipse.platform.ui.tools</groupId>
  <artifactId>eclipse.platform.ui.tools</artifactId>
  <version>0.17.0-SNAPSHOT</version>
  <packaging>pom</packaging>

But, again, feel free to study other "repository poms". 

Its a vague memory, but think we were trying to avoid plain "org.eclipse", because something else in maven central had that group id?
Comment 2 David Williams CLA 2015-04-03 14:44:19 EDT 
Those first too, I should emphasize, would effect all your "child poms" too, since their parent would need to be updated. 

= = = =

Another case that jumps out at me, is that 

your org.eclipse.e4.tools bundle has a group id of 

  <groupId>org.eclipse</groupId>

all others have

  <groupId>org.eclipse.e4</groupId>

So, I think that first one should be changed. 

= = = = = 

No patch for these ... change at will :) 

(But, might want to be sure to do it before I-build, to avoid having to "touch everything" again next week, since "pom only" changes do not effect qualifier. 

Thanks,
Comment 3 Eclipse Genie CLA 2015-04-07 05:55:10 EDT 
New Gerrit change created: https://git.eclipse.org/r/45359
Comment 5 Lars Vogel CLA 2015-04-07 06:06:35 EDT 
David, thanks for your help!

I think I addressed all your issues, please reopen if I missed something.
Comment 6 Lars Vogel CLA 2015-04-28 06:17:24 EDT 
.
Comment 7 Lars Vogel CLA 2015-04-28 15:01:29 EDT 
AFAIK this is OK now