This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 461850 - [eslint] Add no-self-compare rule
Summary: [eslint] Add no-self-compare rule
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: JS Tools (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 11.0   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-10 12:01 EDT by Michael Rennie CLA
Modified: 2015-12-17 14:39 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2015-03-10 12:01:02 EDT 
We should add the no-self-compare rule:

http://eslint.org/docs/rules/no-self-compare.html
Comment 1 Eclipse Genie CLA 2015-12-16 10:48:24 EST 
New Gerrit change created: https://git.eclipse.org/r/62845
Comment 2 Eclipse Genie CLA 2015-12-16 20:38:42 EST 
New Gerrit change created: https://git.eclipse.org/r/62888
Comment 3 Olivier Thomann CLA 2015-12-16 20:40:11 EST 
I abandonned https://git.eclipse.org/r/62845.
The last one is the good one to use.

Curtis, could you please review it?

Thanks.
Comment 4 Eclipse Genie CLA 2015-12-17 13:58:50 EST 
New Gerrit change created: https://git.eclipse.org/r/62958