Community
Participate
Working Groups
(cross posting from equinox-dev after Pascal's advice ;)) While currently trying to build natives on the Eclipse FoundationiInfra (see cbi-dev ML for information and https://hudson.eclipse.org/cbi/view/natives/ for builds), I hit an issue with Mac native launchers. Don't take the green status of https://hudson.eclipse.org/cbi/view/natives/job/cbi-launcher-macosx-x86_64/ for granted. It is actually failing. The issue is that features/org.eclipse.equinox.executable.feature/pom.xml starts features/org.eclipse.equinox.executable.feature/library/carbon/build.xml which itself starts features/org.eclipse.equinox.executable.feature/library/carbon/build.sh build.sh takes arguments about the platform to build but build.xml does not set any. pom.xml on the other hand defines the variable "native" as a string "ws.os.arch". So I updated build.xml to take these string and split it to be able to run build.sh accordingly. See my patch here https://git.eclipse.org/r/#/c/43538/. With this patch, I am able to properly build native launcher my local OS X with the command "mvn clean verify -P build-individual-bundles -Dnative=cocoa.macosx.x86_64 -f rt.equinox.framework/features/org.eclipse.equinox.executable.feature/pom.xml" Another issue is with the "mvn clean". It was not triggering the "build.sh clean" in the end, so I update the features/org.eclipse.equinox.executable.feature/pom.xml for that too (https://git.eclipse.org/r/#/c/43539/1).
Thanks for the bug, and especially patches, but will need to be reviewed and committed by Equinox committer, so moving to their component. Thanks again,
There are many things that we need to stabilize for M6. So, if this is ok with you I'd like to commit this once after M6.
Sure, no problem.
See also bug 383545 ... is the suggestion made there an alternative solution?
Not really. Bug 383545 is about the "cosmetic" renaming of the folder "carbon" to "cocoa" to better reflect that sources within this folder are about cocoa and not carbon. This would be very good, but not related to this bug which about wrong parameters (passed from maven to ant script to shell script) that prevents to build the natives from maven.
Gerrit request pushed.
(In reply to Mikael Barbero from comment #5) > Not really. Bug 383545 is about the "cosmetic" renaming of the folder > "carbon" to "cocoa" to better reflect that sources within this folder are > about cocoa and not carbon. This would be very good, but not related to this > bug which about wrong parameters (passed from maven to ant script to shell > script) that prevents to build the natives from maven. Thanks. I'd still like to see bug 383545 fixed, as I think such so called "cosmetic" errors are what leads to "conceptual errors" in build scripts. Especially as "new people" get involved ... that have to re-learn the quirks and is thus a "barrier to entry".
(In reply to David Williams from comment #7) > I'd still like to see bug 383545 fixed, as I think such so called > "cosmetic" errors are what leads to "conceptual errors" in build scripts. > > Especially as "new people" get involved ... that have to re-learn the quirks > and is thus a "barrier to entry". FYI, I pushed two reviews for bug 383545: https://git.eclipse.org/r/#/c/45375/ https://git.eclipse.org/r/#/c/45376/
