Community
Participate
Working Groups
This dependency is problematic: orion/editor/edit -> cssContentAssist -> csslint It means that every page that uses the editor -- such as edit.js, settings.js, and compareView.js -- now pulls in csslint. CSSLint is huge: 300KB unminified. This feature should not be compiled in by default; the consumer should have to load cssContentAssist.js themselves and register it with the editor.
Created attachment 251298 [details] proposed fix Here is a patch breaking the dependency. I also removes a bunch of unused params, two of them being for the CSS and HTML syntax requires. Mark mentioned removing those might be problematic (but from our testing nothing seems broken). Grant, Silenio, do either of you know if it is 'safe' to remove those unused requires?
I think it should be fine for them to go, verifying that styling of HTML and CSS still works should be an adequate test.
Pushed the patch: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=fd4ba1d0fb8a28c69d7e6973355f6591fc2aff82 then removed the csslint require in the other demo HTML files: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=cac055212649960e098d32818beb3037f318db83
I've created a new wiki page that documents API changes by release, and mentioned this change there https://wiki.eclipse.org/Orion/API_Changelog
