Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 460581 - Cannot edit values in the advanced tab in the properties view
Summary: Cannot edit values in the advanced tab in the properties view
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Views (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 438505
Blocks:
  Show dependency tree
 
Reported: 2015-02-23 04:27 EST by Patrik Nandorf CLA
Modified: 2015-05-18 11:09 EDT (History)
3 users (show)

See Also:


Attachments
The expected behavior (2.83 KB, image/png)
2015-02-23 04:27 EST, Patrik Nandorf CLA
no flags Details
The actual behavior (2.43 KB, image/png)
2015-02-23 04:28 EST, Patrik Nandorf CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrik Nandorf CLA 2015-02-23 04:27:42 EST
Created attachment 251017 [details]
The expected behavior

When trying to edit a value .e.g the name of an element in the advanced tab in the properties view the widget for that value is visually changed to "edit mode". 

That is, the widget isn't showing any changes made until Enter is pressed.

See the attached images for actual and expected behavior.

This is most likely a GTK3/SWT issue.

---

Ubuntu 14.04 / Mars M5 / Papyrus 1.1.0.201502230616

eclipse.buildId=4.5.0.I20150203-1300
java.version=1.7.0_76
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
Framework arguments:  -product org.eclipse.epp.package.committers.product
Command-line arguments:  -os linux -ws gtk -arch x86_64 -product org.eclipse.epp.package.committers.product
Comment 1 Patrik Nandorf CLA 2015-02-23 04:28:00 EST
Created attachment 251018 [details]
The actual behavior
Comment 2 Christian Damus CLA 2015-02-23 09:28:08 EST
I don't understand, even with the attachments.

Do you mean that the property editor does *not* visually enter edit mode?  That you type blindly, not seeing the text that you're typing until you press Enter?
Comment 3 Patrik Nandorf CLA 2015-02-23 09:29:38 EST
(In reply to Christian W. Damus from comment #2)
> I don't understand, even with the attachments.
> 
> Do you mean that the property editor does *not* visually enter edit mode? 
> That you type blindly, not seeing the text that you're typing until you
> press Enter?

Exactly! Thanks for clarifying.
Comment 4 Christian Damus CLA 2015-02-23 09:34:07 EST
Gosh, I was half-hoping that I was joking.  That's not a nice experience!

It does seem to be a GTK3 integration thing.  I get the expected edit behaviour on Mac.

Could you do me a favour and see whether an EMF-generated editor for some Ecore model has the same behaviour?  (in fact, the *.ecore editor itself is a good test)  I doubt that this is in code that Papyrus can influence.
Comment 5 Patrik Nandorf CLA 2015-02-23 09:41:46 EST
(In reply to Christian W. Damus from comment #4)
> Gosh, I was half-hoping that I was joking.  That's not a nice experience!
> 
> It does seem to be a GTK3 integration thing.  I get the expected edit
> behaviour on Mac.
> 
> Could you do me a favour and see whether an EMF-generated editor for some
> Ecore model has the same behaviour?  (in fact, the *.ecore editor itself is
> a good test)  I doubt that this is in code that Papyrus can influence.

Yes it has, and actually to might be even lower,i.e. a SWT thing.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=436324

Seems like GTK3 and SWT are not best friends
https://bugs.eclipse.org/bugs/buglist.cgi?quicksearch=gtk3%20swt

/Patrik
Comment 6 Christian Damus CLA 2015-02-23 09:47:49 EST
Whoa, indeed.

OK, so it seems like the resolution of this bug is "Not Papyrus."  I'm not sure what the Papyrus team's procedure is for that ...
Comment 7 Toni Siljamäki CLA 2015-02-23 13:44:57 EST
Please raise the prio to, at least, major.
Comment 8 Snjezana Peco CLA 2015-05-11 12:15:29 EDT

*** This bug has been marked as a duplicate of bug 438505 ***
Comment 9 Christian Damus CLA 2015-05-12 13:48:38 EDT
The Eclipse Platform GTK3 bug has been fixed, per comment 8.

Patrik, would you be able to confirm this for Papyrus? (given that you have the requisite test environment).  Thanks
Comment 10 Marc-André Laperle CLA 2015-05-12 14:08:13 EDT
(In reply to Christian W. Damus from comment #9)
> The Eclipse Platform GTK3 bug has been fixed, per comment 8.
> 
> Patrik, would you be able to confirm this for Papyrus? (given that you have
> the requisite test environment).  Thanks

You will need tonight's Eclipse build or later, it should be listed as I20150512-2000 when it's available here:
http://download.eclipse.org/eclipse/downloads/
Comment 11 Patrik Nandorf CLA 2015-05-13 06:45:38 EDT
AS I wrote in bug 461041, this still doesn't work even with bug 438505 fixed.
Comment 12 Snjezana Peco CLA 2015-05-18 11:09:49 EDT
Fixed with https://git.eclipse.org/r/47920.