Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 460560 - Add E4 tools to committers package
Summary: Add E4 tools to committers package
Status: RESOLVED FIXED
Alias: None
Product: EPP
Classification: Technology
Component: committers-package (show other bugs)
Version: 4.5.1   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: later   Edit
Assignee: Jonas Helming CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 459799
Blocks:
  Show dependency tree
 
Reported: 2015-02-22 19:00 EST by Alex Blewitt CLA
Modified: 2015-07-16 03:16 EDT (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2015-02-22 19:00:17 EST
Development in E4 requires the E4 tools to be developed. At the moment, the Eclipse IDE promotes development of Eclipse 3.x plug-ins and views because of the lack of built-in tooling for E4 based applications, and/or for the built-in backwards compatibility frameworks (E4 in E3.x) available.

To improve this, and given that the E4 tooling has migrated into its own repository, it would be good to have the E4 tools available in the standard IDE for Eclipse committers so that it can be utilised by developers to encourage adoption of Eclipse 4 APIs and tooling.
Comment 1 Alex Blewitt CLA 2015-02-22 19:01:16 EST
Adding Lars for thoughts.
Comment 2 Mickael Istria CLA 2015-02-23 01:20:49 EST
And also to the RCP package.
Note that e4 tools should soon be moved to Platform https://projects.eclipse.org/projects/eclipse.e4/reviews/move-e4-tools-eclipse-platform-ui
Comment 3 Gunnar Wagenknecht CLA 2015-02-23 14:22:15 EST
I'm open to accept a review for M6. That's about the last milestone to add features to a package.

Alternatively, a list of feature ids is also sufficient. :)
Comment 4 Gunnar Wagenknecht CLA 2015-03-03 06:17:33 EST
Lars, will e4 tools participat in the release train? Will it publish something into the common release repository that I can consume in the package?
Comment 5 Lars Vogel CLA 2015-04-07 06:25:03 EDT
(In reply to Gunnar Wagenknecht from comment #4)
> Lars, will e4 tools participat in the release train? Will it publish
> something into the common release repository that I can consume in the
> package?

Build should be ready with todays I-build. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=459799
Comment 6 Jonas Helming CLA 2015-05-26 11:28:21 EDT
Is this done? the tools are already inegtrated into the RCP and modeling package...
Comment 7 Lars Vogel CLA 2015-06-18 04:34:40 EDT
(In reply to Jonas Helming from comment #6)
> Is this done? the tools are already inegtrated into the RCP and modeling
> package...

Gunnar just said via Twitter that he wants a Gerrit review. Can you do this Jonas?
Comment 8 Jonas Helming CLA 2015-06-18 04:57:02 EDT
As discussed on twitter, it is too late now for Mars, I will do this for SR1

:-(
Comment 9 Gunnar Wagenknecht CLA 2015-06-18 05:01:43 EDT
Adding Markus for feedback.
Comment 10 Lars Vogel CLA 2015-06-18 05:02:03 EDT
Gerrit review can be done now to avoid any delay for SR1.
Comment 11 Jonas Helming CLA 2015-06-18 05:05:21 EDT
@Gunnar: It is to late for Mars, I will add it to SR1
Comment 12 Gunnar Wagenknecht CLA 2015-06-18 05:05:54 EDT
https://dev.eclipse.org/mhonarc/lists/epp-dev/msg03579.html
Comment 13 Gunnar Wagenknecht CLA 2015-06-18 05:12:56 EDT
OK, so we are rebuilding the packages for Mars. Markus is considering a change for the JEE package. If you can provide a review today, I'd give it my +2, given that it already works successfully in other packages.

If Markus also +1 it then it could be in Mars.
Comment 14 Markus Knauer CLA 2015-06-18 05:25:18 EDT
The change in the Java EE package is a bit different from this here. In the Java EE case it is done to mitigate a bad user experience, which isn't the case here.

I'd suggest to use SR1 to add this feature to the package.
Comment 15 Mickael Istria CLA 2015-06-18 05:38:41 EDT
(In reply to Markus Knauer from comment #14)
> The change in the Java EE package is a bit different from this here. In the
> Java EE case it is done to mitigate a bad user experience, which isn't the
> case here.

Promoting E4 Tools as a top feature of this release and not including it in the committer package is also a bad user experience IMO. Since there is time, and there will be respin anyway, it would be a shame to not being agile enough to integrate such a patch.
(Less than my 2c, as I actually use the RCP package and have claimed multiple times the Committers package is the one too many anyway)
Comment 16 Alex Blewitt CLA 2015-06-18 05:59:53 EDT
It is a mistake to release the IDE for committers without the tools needed to commit against Eclipse 4. I would not advocate adding it to other packages but it is crazy to not have it in the very package that needs it.
Comment 17 Eclipse Genie CLA 2015-06-18 06:12:49 EDT
New Gerrit change created: https://git.eclipse.org/r/50414
Comment 18 Jonas Helming CLA 2015-06-18 06:17:24 EDT
We have just created a gerrit, which adds the e4 tools, but I am actually not in favor to push it into Mars, but apply it for SR1 instead.

For 3 major releases, meaning for 3 years, the tools have not been graduated nor been part of any EP. I did not like this situation, especially for new people, that is why we moved the e4 tools.
However, all people who use e4 know that they have to install the tool, so I think waiting another 3 month to make them available doesn't sound crazy. Additionally, I expect the committer package to be used by expert users. Finally, I almost never need the e4 tools to commit to the platform. Still I agree, that is is bad, that the tools did not make it inot that package.

No offense to anyone, but this BR was created 4 month ago. Since 2 month the tools were available to be added. I even pinged the BR again 1 month ago. Now we start a huge discussion 2 days after the final deadline.

The mentioned re-spin was clearly announced to only allow the discussed change and freeze all other contributions. I think in an agile process it is still important to respect some rules and one is that if something is not finished until a deadline it is move to the next milestone rather than shifting the deadline. Probably the change does not harm to the EP, but if we allow another change for the re-spin, probably other projects want to add other changes, too.

Just my 2 cents, this is not my decision anyways...
Comment 19 Markus Knauer CLA 2015-06-18 06:38:56 EDT
Right now we are in quiet week before our release, and only going to make changes if there are blockers, stop-ship bugs, or legal reasons that force us to take action. All other changes need to wait until SR1.

For this enhancement request there are several options: Use a different package that has the E4 tools included, or install them from the preconfigured Mars p2 repository.
Comment 21 Lars Vogel CLA 2015-07-16 00:47:55 EDT
I think this was fixed for Mars, please reopen if I'm wrong.
Comment 22 Alex Blewitt CLA 2015-07-16 03:08:34 EDT
It was not in Mars for the committers package. It may be added in SR1.